-
Notifications
You must be signed in to change notification settings - Fork 1
refactor(graphics): cache bytesPerRow in MonochromeBitmap #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(graphics): cache bytesPerRow in MonochromeBitmap #118
Conversation
Cached the bytesPerRow calculation in MonochromeBitmap struct to avoid duplicated calculations and improve maintainability. Updated NewMonochromeBitmap to initialize the field and other methods to use it. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
👋 Thanks for opening this PR, @adcondev! Here's what will happen next:
Please make sure:
|
⚡ Benchmark Results📈 Performance Comparison📊 Click to expand detailed resultsCurrent Branch ResultsBase Branch Results💡 Note: Use 🎯 Summary
|
…-17139310501292623649
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the MonochromeBitmap struct to cache the bytesPerRow calculation, eliminating redundant computations and improving code maintainability.
Changes:
- Added a
bytesPerRowfield to cache the(Width + 7) / 8calculation - Updated
NewMonochromeBitmapto initialize the cached field - Modified
SetPixel,GetPixel,GetWidthBytes, andToImagemethods to use the cached value instead of recalculating
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactored MonochromeBitmap to cache the bytesPerRow calculation in a private field. This removes duplicated calculations in SetPixel, GetPixel, ToImage and GetWidthBytes, improving maintainability and slightly optimizing performance.
Changes:
bytesPerRowfield toMonochromeBitmapstruct.NewMonochromeBitmapto initializebytesPerRow.SetPixel,GetPixel,GetWidthBytes, andToImageto use the cachedbytesPerRow.PR created automatically by Jules for task 17139310501292623649 started by @adcondev