-
Notifications
You must be signed in to change notification settings - Fork 1
test(calculate): add unit tests for calculation utilities #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Add table-driven tests for DotsPerLine, MmToDots, and DotsToMm functions in the internal/calculate package. Tests cover: - Standard paper widths (80mm, 58mm) and DPIs (203, 180). - Zero width/dots/mm scenarios. - Negative input handling. - Edge cases like zero DPI (verifying behavior). This ensures the accuracy of fundamental unit conversions used throughout the library. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
👋 Thanks for opening this PR, @adcondev! Here's what will happen next:
Please make sure:
|
⚡ Benchmark Results📈 Performance Comparison📊 Click to expand detailed resultsCurrent Branch ResultsBase Branch Results💡 Note: Use 🎯 Summary
|
🎯 What: The testing gap addressed is the lack of unit tests for the
internal/calculatepackage, specifically forDotsPerLine,MmToDots, andDotsToMmfunctions.📊 Coverage: The tests now cover standard scenarios (e.g., 80mm/58mm paper at 203 DPI), zero values, negative inputs (where applicable), and edge cases like zero DPI.
✨ Result: The improvement in test coverage ensures the accuracy of these fundamental unit conversion utilities and prevents regressions.
PR created automatically by Jules for task 1365553061994360617 started by @adcondev