element removal with remaining elements filling in the gaps#35
Open
dandohotaru wants to merge 4 commits intoademilter:masterfrom
dandohotaru:feature-remove
Open
element removal with remaining elements filling in the gaps#35dandohotaru wants to merge 4 commits intoademilter:masterfrom dandohotaru:feature-remove
dandohotaru wants to merge 4 commits intoademilter:masterfrom
dandohotaru:feature-remove
Conversation
add support for item removal on item click. add support for first item removal via button.
dandohotaru
changed the title
Collaborator
|
Wow this looks like a huge change, we need to test that, then we'll accept it. Great work btw, thanks! |
|
Yes please! this is is what bricklayerJS is missing! |
Author
|
well, in case there is anything i, as the author of the pull request, can do to improve the likelihood of the pull request to be accepted or rejected, let me know... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for certain scenarios,
besides append and prepend,
one may want to remove an element
and all the other elements to redraw to fill in the gaps...
enhanced the demo as well with remove on click