Open
Conversation
* add coveralls badge * implement BFA feedback
* add coveralls badge * implement BFA feedback * add codeclimate badge. add dist files. update package.json * update readme.md * add test db * add dist/ files * update readme.md
* add coveralls badge * implement BFA feedback * add codeclimate badge. add dist files. update package.json * update readme.md * add test db * add dist/ files * update readme.md * update route and middleware
* add coveralls badge * implement BFA feedback * add codeclimate badge. add dist files. update package.json * update readme.md * add test db * add dist/ files * update readme.md * update route and middleware * update sequelizerc (#25)
* add coveralls badge * implement BFA feedback * add codeclimate badge. add dist files. update package.json * update readme.md * add test db * add dist/ files * update readme.md * update route and middleware * update sequelizerc (#25) * Implement bfa feedback merge (#27) * update sequelizerc * update index.js * Update route index.js
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke * bug(make-test-pass): make test pass on travis * feature(social-auth): add facebook and google social login * bug(bug-fix): change the order of users migration files * feat(reset-password): reset password on client side * chore(server-test): refactor server test to separate folders * chore(reactor-readme): implement LF feedback by refactoring readme file * chore(server): refactor server side to use express-api-versioning to dynamically route between different api versions
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke * bug(make-test-pass): make test pass on travis * feature(social-auth): add facebook and google social login * bug(bug-fix): change the order of users migration files * feat(reset-password): reset password on client side * chore(server-test): refactor server test to separate folders * chore(reactor-readme): implement LF feedback by refactoring readme file * chore(server): refactor server side to use express-api-versioning to dynamically route between different api versions * chore(stabilize-base-application): stabilize base application for deployment on Heroku - remove jquery dependency - remove client build from VC - add env.sample files to client and server applications - rename folders to follow airbnb style guide - make client app build on Heroku - remove extraneous dependecies in client app - add disqus for reviewing a book - add webpack alias for eslint
…to development
… and add category forms
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke * bug(make-test-pass): make test pass on travis * feature(social-auth): add facebook and google social login * bug(bug-fix): change the order of users migration files * feat(reset-password): reset password on client side * chore(server-test): refactor server test to separate folders * chore(client-validation): add client side validation to sigin, signup and add category forms
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke * bug(make-test-pass): make test pass on travis * feature(social-auth): add facebook and google social login * bug(bug-fix): change the order of users migration files * feat(reset-password): reset password on client side * chore(server-test): refactor server test to separate folders * chore(client-validation): add client side validation to sigin, signup and add category forms * bug(bug-fix): fix bug that doesn't allow users add a book in production
…to development
* chore(implement-lf-feedback): implement LF feedback during code defence with Temi Lajumoke * bug(make-test-pass): make test pass on travis * feature(social-auth): add facebook and google social login * bug(bug-fix): change the order of users migration files * feat(reset-password): reset password on client side * chore(server-test): refactor server test to separate folders * chore(client-validation): add client side validation to sigin, signup and add category forms * bug(bug-fix): fix bug that doesn't allow users add a book in production * bug(bug-fix): refactor error handling when book can't be added - add page loader - remove documentPath from book validation - remove extraneous dependencies in client
…to development
… returns a book (#74)
…to development
…to development
- rename server controller and model file naming convention - rewrite the way errors are sent in server - test actual values in server test
- fix user should be able to change password feeature - refactor readme documentation - remove multiple eslint config files - fix restart dyno issues in production - add JSDOC documentation to server and client side code
- change `data` variable name - add error boundary to resolve component errors in production
…ponse from the server
- account for potential errors by adding catch callbacks to some model calls - change error messages to be more descriptive - use approprite status code in user controller - fix uneven background height on different viewport
houndci-bot
reviewed
Jan 8, 2018
| @@ -0,0 +1,59 @@ | |||
| import models from '../../models'; | |||
| import { user, admin } from './user'; | |||
| import utils from '../../utils'; | |||
There was a problem hiding this comment.
Unable to resolve path to module '../../utils' import/no-unresolved
Missing file extension for "../../utils" import/extensions
| @@ -0,0 +1,59 @@ | |||
| import models from '../../models'; | |||
| import { user, admin } from './user'; | |||
There was a problem hiding this comment.
Unable to resolve path to module './user' import/no-unresolved
Missing file extension for "./user" import/extensions
| @@ -0,0 +1,59 @@ | |||
| import models from '../../models'; | |||
There was a problem hiding this comment.
Unable to resolve path to module '../../models' import/no-unresolved
Missing file extension for "../../models" import/extensions
| import supertest from 'supertest'; | ||
| import app from '../../../../express'; | ||
| import { user } from '../seeds/user'; | ||
| import { generateToken } from '../seeds'; |
There was a problem hiding this comment.
Unable to resolve path to module '../seeds' import/no-unresolved
Missing file extension for "../seeds" import/extensions
| import chai from 'chai'; | ||
| import supertest from 'supertest'; | ||
| import app from '../../../../express'; | ||
| import { user } from '../seeds/user'; |
There was a problem hiding this comment.
Unable to resolve path to module '../seeds/user' import/no-unresolved
Missing file extension for "../seeds/user" import/extensions
| } | ||
|
|
||
| if (type === "signup" || | ||
| type === "change-password" || |
There was a problem hiding this comment.
Strings must use singlequote quotes
| } | ||
| } | ||
|
|
||
| if (type === "signup" || |
There was a problem hiding this comment.
Strings must use singlequote quotes
| if (type === "signup" || | ||
| type === "login" || | ||
| type === "change-password" || | ||
| type === "change-password-user") { |
There was a problem hiding this comment.
Strings must use singlequote quotes
|
|
||
| if (type === "signup" || | ||
| type === "login" || | ||
| type === "change-password" || |
There was a problem hiding this comment.
Strings must use singlequote quotes
| } | ||
|
|
||
| if (type === "signup" || | ||
| type === "login" || |
There was a problem hiding this comment.
Strings must use singlequote quotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.