Fix for grammar parser returning MATCH_END when partial match items exist#33
Open
emcgee wants to merge 4 commits intoadhearsion:developfrom
Open
Fix for grammar parser returning MATCH_END when partial match items exist#33emcgee wants to merge 4 commits intoadhearsion:developfrom
emcgee wants to merge 4 commits intoadhearsion:developfrom
Conversation
Member
|
Could we add test cases similar to those in the FS change to demonstrate the issue? |
Member
|
Also, a rebase on the current develop branch for a passing test suite would be awesome :) |
Author
|
Rebased, although entirely unsure of how to add an appropriate spec for this based on the SRGS tests in FS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to match corresponding change in FreeSWITCH mod_rayo: https://stash.freeswitch.org/projects/FS/repos/freeswitch/commits/28bc992fcedbdf7814556074da856944fcbd9bfe#src/mod/event_handlers/mod_rayo/srgs.c