Criticall: convert leading spaces to tabs

.github/workflows/code-quality.yml

@@ -0,0 +1,53 @@
+name: Code Quality
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+on:
+  push:
+    branches: [main, master]
+  pull_request:
+    branches: [main, master]
+
+jobs:
+  format-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.13"
+
+      - name: Install Poetry
+        run: pipx install poetry
+
+      - name: Install dependencies
+        run: poetry install
+
+      - name: Check code formatting
+        run: poetry run ruff format --check .
+
+      - name: Run ruff linter
+        run: poetry run ruff check .
+
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Set up Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.13"
+
+      - name: Install Poetry
+        run: pipx install poetry
+
+      - name: Install dependencies
+        run: poetry install
+
+      - name: Run pre-commit checks
+        uses: pre-commit/action@v3.0.0

.pre-commit-config.yaml

@@ -5,3 +5,10 @@ repos:
       - id: check-ast
       - id: check-case-conflict
       - id: check-yaml
+
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.3.5
+    hooks:
+      - id: ruff-format
+      - id: ruff
+        args: [--fix]

.vscode/typings/__builtins__.pyi

@@ -1,6 +1,2 @@
-def _(msg: str) -> str:
-	...
-
-
-def pgettext(context: str, message: str) -> str:
-	...
+def _(msg: str) -> str: ...
+def pgettext(context: str, message: str) -> str: ...

addon/globalPlugins/quickNotetaker/__init__.py

@@ -5,7 +5,6 @@
 # This file is covered by the GNU General Public License.
 # See the file COPYING for more details.
 
-from logHandler import log
 import globalPluginHandler
 from scriptHandler import script
 import gui
@@ -24,61 +23,59 @@
 
 
 class GlobalPlugin(globalPluginHandler.GlobalPlugin):
+	def __init__(self, *args, **kwargs):
+		super(GlobalPlugin, self).__init__(*args, **kwargs)
+		addonConfig.initialize()
+		notesManager.initialize()
+		try:
+			os.mkdir(addonConfig.getValue("notesDocumentsPath"))
+		except FileNotFoundError:
+			# The user has no documents directory
+			# Create the add-on documents folder in the user root folder instead
+			addonConfig.setValue("notesDocumentsPath", os.path.expanduser("~\\QuickNotetaker"))
+			os.mkdir(addonConfig.getValue("notesDocumentsPath"))
+		except FileExistsError:
+			pass
+		try:
+			os.mkdir(TEMP_FILES_PATH)
+		except FileExistsError:
+			pass
+		gui.settingsDialogs.NVDASettingsDialog.categoryClasses.append(QuickNotetakerPanel)
 
-    def __init__(self, *args, **kwargs):
-        super(GlobalPlugin, self).__init__(*args, **kwargs)
-        addonConfig.initialize()
-        notesManager.initialize()
-        try:
-            os.mkdir(addonConfig.getValue("notesDocumentsPath"))
-        except FileNotFoundError:
-            # The user has no documents directory
-            # Create the add-on documents folder in the user root folder instead
-            addonConfig.setValue("notesDocumentsPath", os.path.expanduser("~\\QuickNotetaker"))
-            os.mkdir(addonConfig.getValue("notesDocumentsPath"))
-        except FileExistsError:
-            pass
-        try:
-            os.mkdir(TEMP_FILES_PATH)
-        except FileExistsError:
-            pass
-        gui.settingsDialogs.NVDASettingsDialog.categoryClasses.append(
-            QuickNotetakerPanel)
+	def terminate(self):
+		super(GlobalPlugin, self).terminate()
+		gui.settingsDialogs.NVDASettingsDialog.categoryClasses.remove(QuickNotetakerPanel)
+		if not os.path.isdir(TEMP_FILES_PATH):
+			return
+		for file in os.listdir(TEMP_FILES_PATH):
+			os.remove(os.path.join(TEMP_FILES_PATH, file))
 
-    def terminate(self):
-        super(GlobalPlugin, self).terminate()
-        gui.settingsDialogs.NVDASettingsDialog.categoryClasses.remove(
-            QuickNotetakerPanel)
-        if not os.path.isdir(TEMP_FILES_PATH):
-            return
-        for file in os.listdir(TEMP_FILES_PATH):
-            os.remove(os.path.join(TEMP_FILES_PATH, file))
+	# Translators: the name of the add-on category in input gestures
+	scriptCategory = _("Quick Notetaker")
 
-    # Translators: the name of the add-on category in input gestures
-    scriptCategory=_("Quick Notetaker")
+	@script(
+		# Translators: the description for the command to open the notetaker dialog
+		description=_("Shows the Notetaker interface for writing a new note"),
+		gesture="kb:NVDA+alt+n",
+	)
+	def script_showNoteTakerUI(self, gesture):
+		noteTitle = None
+		if addonConfig.getValue("captureActiveWindowTitle"):
+			noteTitle = api.getForegroundObject().name
+		gui.mainFrame.prePopup()
+		dialogs.noteTakerInstance = NoteTakerDialog(noteTitle=noteTitle)
+		dialogs.noteTakerInstance.Show()
+		gui.mainFrame.postPopup()
 
-    @ script(
-        # Translators: the description for the command to open the notetaker dialog
-        description=_("Shows the Notetaker interface for writing a new note"),
-        gesture="kb:NVDA+alt+n"
-    )
-    def script_showNoteTakerUI(self, gesture):
-        noteTitle=None
-        if addonConfig.getValue("captureActiveWindowTitle"):
-            noteTitle=api.getForegroundObject().name
-        gui.mainFrame.prePopup()
-        dialogs.noteTakerInstance=NoteTakerDialog(noteTitle=noteTitle)
-        dialogs.noteTakerInstance.Show()
-        gui.mainFrame.postPopup()
-
-    @ script(
-        description=_(
-            # Translators: the description for the command to open the Notes Manager
-            "Shows the Notes Manager interface for viewing and managing notes"),
-        gesture="kb:NVDA+alt+v"
-    )
-    def script_showNotesManagerDialogUI(self, gesture):
-        gui.mainFrame.prePopup()
-        dialogs.notesManagerInstance=NotesManagerDialog()
-        dialogs.notesManagerInstance.Show()
-        gui.mainFrame.postPopup()
+	@script(
+		description=_(
+			# Translators: the description for the command to open the Notes Manager
+			"Shows the Notes Manager interface for viewing and managing notes"
+		),
+		gesture="kb:NVDA+alt+v",
+	)
+	def script_showNotesManagerDialogUI(self, gesture):
+		gui.mainFrame.prePopup()
+		dialogs.notesManagerInstance = NotesManagerDialog()
+		dialogs.notesManagerInstance.Show()
+		gui.mainFrame.postPopup()

addon/globalPlugins/quickNotetaker/addonConfig.py

@@ -11,30 +11,30 @@
 
 
 def initialize():
-    configSpec = {
-        "notesDocumentsPath": f"string(default={os.path.normpath(os.path.expanduser('~/documents/quickNotetaker'))})",
-        "askWhereToSaveDocx": "boolean(default=False)",
-        "openFileAfterCreation": "boolean(default=False)",
-        "captureActiveWindowTitle": "boolean(default=True)",
-        "rememberTakerSizeAndPos": "boolean(default=False)",
-        "autoAlignText": "boolean(default=true)",
-        "takerXPos": f"integer(default={wx.DefaultPosition.x})",
-        "takerYPos": f"integer(default={wx.DefaultPosition.y})",
-        "takerWidth": "integer(default=500)",
-        "takerHeight": "integer(default=500)",
-    }
-    config.conf.spec["quickNotetaker"] = configSpec
+	configSpec = {
+		"notesDocumentsPath": f"string(default={os.path.normpath(os.path.expanduser('~/documents/quickNotetaker'))})",
+		"askWhereToSaveDocx": "boolean(default=False)",
+		"openFileAfterCreation": "boolean(default=False)",
+		"captureActiveWindowTitle": "boolean(default=True)",
+		"rememberTakerSizeAndPos": "boolean(default=False)",
+		"autoAlignText": "boolean(default=true)",
+		"takerXPos": f"integer(default={wx.DefaultPosition.x})",
+		"takerYPos": f"integer(default={wx.DefaultPosition.y})",
+		"takerWidth": "integer(default=500)",
+		"takerHeight": "integer(default=500)",
+	}
+	config.conf.spec["quickNotetaker"] = configSpec
 
 
 def getValue(key):
-    try:
-        return config.conf["quickNotetaker"][key]
-    except KeyError:
-        # Config key doesn't exist, likely upgrading from older version
-        # Re-initialize config to ensure all defaults are set
-        initialize()
-        return config.conf["quickNotetaker"][key]
+	try:
+		return config.conf["quickNotetaker"][key]
+	except KeyError:
+		# Config key doesn't exist, likely upgrading from older version
+		# Re-initialize config to ensure all defaults are set
+		initialize()
+		return config.conf["quickNotetaker"][key]
 
 
 def setValue(key, value):
-    config.conf["quickNotetaker"][key] = value
+	config.conf["quickNotetaker"][key] = value

addon/globalPlugins/quickNotetaker/constants.py

@@ -7,7 +7,6 @@
 
 import globalVars
 import os
-import sys
 import shutil
 import config