Handling system tables errors#16
Open
chanukya571 wants to merge 3 commits intoadjust:handling-system-tables-errorsfrom
Open
Handling system tables errors#16chanukya571 wants to merge 3 commits intoadjust:handling-system-tables-errorsfrom
chanukya571 wants to merge 3 commits intoadjust:handling-system-tables-errorsfrom
Conversation
Author
|
@za-arthur Please review this. Once this is merged I will create a Pull request from adjust/pg_repack to reorg/pg_repack. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey All,
Sorry for delay. there is a problem with my email.
As mentioned I have reviewed the code and did some cleanup , added comments also.
As per suggestions on PR reorg#327 I have looked in both
repack_one_table()andrepack_table_indexes()but theERROR: relation pg_class does not existis coming fromis_requested_relation_exists()before checking the functioncheck_systemtables().So I have added
check_systemtables()inis_requested_relation_exists()so that it will be clear for understanding and enhance in future.Please let me know your thoughts. once this branch is merged I will create pull request to reorg/pg_repack.
Thanks.