Open
Conversation
| { | ||
| 'id': 'asset-details-extension-tab', | ||
| 'id': 'asset-details-extension-tab-1', | ||
| 'tooltip': 'Asset Details Extension Tab', |
Contributor
There was a problem hiding this comment.
Kindly create new extension button and panel here.
.../src/aem-contenthub-assets-details-1/web-src/src/components/PanelAssetDetailsExtensionTab.js
Show resolved
Hide resolved
| /** | ||
| * Configuration constants | ||
| */ | ||
| const CONFIG = { |
| * Configuration constants | ||
| */ | ||
| const CONFIG = { | ||
| backendUrl: 'https://274796-chextn-stage.adobeio-static.net/api/v1/web/aem-contenthub-assets-details-1/generic', |
Contributor
There was a problem hiding this comment.
seems like a magic url, can you make it dynamic?
Author
There was a problem hiding this comment.
https://274796-chextn-stage.adobeio-static.net/api/v1/web/aem-contenthub-assets-details-1/generic
274796-chextn-stage = Adobe I/O Runtime namespace
aem-contenthub-assets-details-1/generic = package/action names from ext.config.yaml
Contributor
There was a problem hiding this comment.
I get it, but don't you think hard-coding this is not a good idea?
...ple/src/aem-contenthub-assets-details-1/web-src/src/components/PanelWorkfrontExtensionTab.js
Show resolved
Hide resolved
...ontenthub-assets-details-sample/src/aem-contenthub-assets-details-1/actions/generic/index.js
Outdated
Show resolved
Hide resolved
.../src/aem-contenthub-assets-details-1/web-src/src/components/PanelAssetDetailsExtensionTab.js
Show resolved
Hide resolved
saksbhardwaj
approved these changes
Sep 30, 2025
Contributor
saksbhardwaj
left a comment
saksbhardwaj
left a comment
There was a problem hiding this comment.
overall flow looks good to me, except one minor comment of hardcoding config url.
mohitar1
reviewed
Oct 7, 2025
mohitar1
reviewed
Oct 7, 2025
mohitar1
reviewed
Oct 7, 2025
mohitar1
reviewed
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: