feat: panel refinements - toggles, no WCs, persistence#315
feat: panel refinements - toggles, no WCs, persistence#315auniverseaway wants to merge 1 commit intoew-panelsfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
|
@hannessolo I really love the approach to panels. Two things about this PR:
Hopefully this works for you! |
|
Some non-critical open questions / comments: We could easily ditch the fragments in favor of just loading a block directly. We would lose flexibility in that we could associate different blocks in authoring without a release, but I'm not sure we would actually use this. We may want to slice this differently anyway... It seems like we pretty much know what we want each panel to always be:
I think this is good for now. Later down the road we may want to allow different views to determine what panels they get. This will be especially true if the auxilery panel becomes a nightmare to support. |
utils/panel.js with plain DOM createPanel/showPanel/hidePanel functions
improved parseWindowPath (returns null for invalid, strips /index)
meta-content attribute selectors
test mocks (IMS, CSS)
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Panels
https://nx2fixes--da-nx--adobe.aem.page/drafts/cmillar/panels
DA.LIVE prod + this NX2 PR + NX1
https://main--da-live--adobe.aem.live/?nx=nx2fixes
Expectation: this works E2E
DA.LIVE stage + this NX2 PR + NX2
https://dasites--da-live--adobe.aem.page/?nx=nx2fixes&nxver=2
Expectation: only da homepage works, but is correctly styled