Added periodic client refresh for e2e monitoring.#9
Open
azun wants to merge 18 commits intoadobe:mainfrom
Open
Added periodic client refresh for e2e monitoring.#9azun wants to merge 18 commits intoadobe:mainfrom
azun wants to merge 18 commits intoadobe:mainfrom
Conversation
…topic in a consumer group ADDENDUM Lower cardinality by not exporting group size for un-stable groups
…ividual metrics Export as numerical metrics: - topic_info_partitions_count - topic_info_replication_factor - topic_info_min_insync_replicas - topic_info_retention_ms Partial fix for redpanda-data#116
Instead report a single global counter metric: kminio_kafka_consumer_group_info_empty_groups
Filter consumer groups when they are listed to avoid caching ignored groups.
This is useful to capture the total number of groups in kafka
This is required in containerised environments to properly set GOMAXPROCS to actual container limits set and not the whole underlying node's CPUs See: https://github.com/uber-go/automaxprocs
* Expose max timestamp for each topic and/or partition Kafka 3.0+ added support to fetch offset with the max timestamp. This is useful in monitoring the steady progress of producing to a topic/partion but also to detect very high timestamps in the topic that can stuck topic retention. This patch adds two new metrics: - kafka_topic_partition_max_timestamp: for each topic partition reports the max timestamp in that partition - kafka_topic_max_timestamp: for each topic reports the max timestamp in that topic, computed as the maximum timestamp across partitions See: - https://issues.apache.org/jira/browse/KAFKA-12541 - https://cwiki.apache.org/confluence/display/KAFKA/KIP-734%3A+Improve+AdminClient.listOffsets+to+return+timestamp+and+offset+for+the+record+with+the+largest+timestamp * Update prometheus/collect_topic_partition_offsets.go
* Filter empty consumer groups * Collect metrics for a set of CG states * Update minion/config_consumer_group.go Co-authored-by: Adrian Muraru <adi.muraru@gmail.com> * Implement review * Implement review * Update the CG state values --------- Co-authored-by: Adrian Muraru <adi.muraru@gmail.com>
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-5776809 - https://snyk.io/vuln/SNYK-ALPINE317-OPENSSL-5776809 Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Fixed consumer group monitoring flag Fixed topic management reconciliation
cristianpetrache
approved these changes
Sep 26, 2023
cristianpetrache
approved these changes
Oct 10, 2023
amuraru
force-pushed
the
main
branch
5 times, most recently
from
ac2fd4d to
df9fc59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for periodic reconnect of kafkaClient to e2e
Fixed consumer group monitoring flag
Fixed topic management reconciliation
Related Issue
Motivation and Context
Some network scenarios allow for already connected clients to keep working while new ones are failing
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: