Add chart animations to Area, Bar, Line, and (opacity-only) Scatter#224
Open
jacob-hart wants to merge 121 commits intomainfrom
Open
Add chart animations to Area, Bar, Line, and (opacity-only) Scatter#224jacob-hart wants to merge 121 commits intomainfrom
jacob-hart wants to merge 121 commits intomainfrom
Conversation
* chore: add timer value to signals * fix: remove debug from chart.story.tsx * chore: add tests for timer signal * fix: remove debug
* chore: add timer value to signals * fix: remove debug from chart.story.tsx * chore: add tests for timer signal * fix: remove debug * feat: add previous data table to data * fix: fix broken test * fix: remove debug
…until animations finished
Nathaniel judd/byu team/animations
Add animation easing
… aren't exactly equal
Contributor
Author
|
Bug with trendline switch animations has been resolved: Screen.Recording.2024-04-12.at.10.59.51.AM.mov |
…y check to rscChart (even though it will always be defined by that point)
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-224 |
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the following animations
The animations are enabled in a new story section called "Animations"
Known Bugs
TrellisHorizontalBarSwitch changes the data in a way that always does animation from zero, not from existing data.RESOLVEDTrendlineZero story doesn't change the data enough to trigger an animation from zeroRESOLVEDHow Has This Been Tested?
We built animations in a backwards-compatible way so the existing test suite would continue to work. We have incrementally added animation-focused tests, as well as extensive manual testing.
Note: there are some Sonar failures in this first revision. We are planning to fast-follow with fixes, but want this PR up to gather feedback earlier!
Screenshots (if appropriate):
Screen.Recording.2024-04-03.at.3.56.10.PM.mov
Screen.Recording.2024-04-01.at.10.27.19.AM.mov
Screen.Recording.2024-04-03.at.3.57.05.PM.mov
Types of changes
Checklist: