fix(dialog): adjust button alignment in footer and add test for button stretch behavior#6229
Open
JinMokai wants to merge 4 commits into
Open
fix(dialog): adjust button alignment in footer and add test for button stretch behavior#6229JinMokai wants to merge 4 commits into
JinMokai wants to merge 4 commits into
Conversation
…n stretch behavior
🦋 Changeset detectedLatest commit: 91cb1b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 83 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Hi @JinMokai I have added you as a collaborator. You can now point this to |
Rajdeepc
added
Contribution
Contributor
|
@JinMokai can you please fill out the entirety of the PR description, include manual testing and a11y testing instructions and complete a self-review of the PR leaving comments with context to whats being introduced to assist reviewers in understanding quickly and reduce feedback. Adding a blocked label until this addressed, please remove that label once you've addressed this. |
caseyisonit
added
the
blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix(dialog): adjust button alignment in footer and add test for button stretch behavior
Motivation and context
Learn adobe swc component knowledge.just passion!
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.