Skip to content

feat(accordion): migrate to 2nd-gen#6268

Draft
rise-erpelding wants to merge 2 commits into
mainfrom
swc-1854/accordion-migration
Draft

feat(accordion): migrate to 2nd-gen#6268
rise-erpelding wants to merge 2 commits into
mainfrom
swc-1854/accordion-migration

Conversation

@rise-erpelding
Copy link
Copy Markdown
Collaborator

@rise-erpelding rise-erpelding commented May 11, 2026

Description

Feature branch for migration of the Accordion component to 2nd-gen

Motivation and context

Related issue(s)

  • fixes [SWC-1854]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Items to address


Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.

    1. Go here
    2. Do this action
    3. Expect this result
  • Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.

    1. Go here
    2. Do this action
    3. Expect this result

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

⚠️ No Changeset found

Latest commit: f741213

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rise-erpelding rise-erpelding added Status:WIP PR is a work in progress or draft Component:Accordion do-not-merge NO MERGE-Y! 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. labels May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6268

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@rise-erpelding rise-erpelding force-pushed the swc-1854/accordion-migration branch from e64ac01 to 66d4919 Compare May 12, 2026 01:52
@rise-erpelding rise-erpelding force-pushed the swc-1854/accordion-migration branch from 66d4919 to 424db20 Compare May 13, 2026 13:12
@rise-erpelding rise-erpelding force-pushed the swc-1854/accordion-migration branch from 78ee04e to 432f56c Compare May 14, 2026 20:30
Co-authored-by: Nikki Massaro <massaro@adobe.com>
@rise-erpelding rise-erpelding force-pushed the swc-1854/accordion-migration branch from 432f56c to 057a70a Compare May 20, 2026 13:33
* chore: scaffold core package

* chore: scaffold swc package

* chore: add Chevron300Icon for xl accordion

* chore: set up storybook story

* chore: commit preview.ts updates

* feat: implement AccordionItem API and render template

* feat: implement Accordion API and propagation

* feat: implement open and toggle logic

* feat: wire up dynamic heading levels

* feat: implement disabled item functionality

* fix: handle space keyboard behavior (SWC-1487)

* refactor: address missing migration-setup items

* refactor: rename methods, align file names

* refactor: typing, heading rendering, sizing

* refactor: move toggle() into base, smooth a11y behavior

* refactor: use assignedItems() helper

* test: add a11y tests

* docs: add a11y docs

* fix: freeze accordion open state when disabled

* feat: 1st-gen deprecation warnings/tests

* docs: jsdoc comments

* chore: changeset

* fix: revert 1st-gen refactor work

* chore(accordion): defer tests, deprecations, and changeset to part two

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: class selectors

* refactor: use ObserveSlotPresence instead of bespoke method

* refactor: remove stop propagation on actions container

* refactor: add open/close events

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Component:Accordion do-not-merge NO MERGE-Y! Status:WIP PR is a work in progress or draft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants