chore(close-button): migration guide#6322
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
d580fd2 to
f9b9450
Compare
|
|
||
| ### Most blocking open questions | ||
|
|
||
| - [Q2](#architecture-and-behavior): Confirm whether `icon-size` should be a public API in SWC or kept internal. |
There was a problem hiding this comment.
| - [Q2](#architecture-and-behavior): Confirm whether `icon-size` should be a public API in SWC or kept internal. | |
| - [Q1](#architecture-and-behavior): Confirm whether `icon-size` should be a public API in SWC or kept internal. |
|
|
||
| --- | ||
|
|
||
| ## Blockers and open questions |
There was a problem hiding this comment.
Should these be formatted as a table? https://github.com/adobe/spectrum-web-components/blob/main/.ai/skills/migration-prep/assets/migration-prep-template.md#blockers-and-open-questions ✨
|
|
||
| - `swc-close-button` should ship as a dedicated 2nd-gen component in both `core` and `swc` layers, not as an extension point buried inside `swc-button`. | ||
| - API should align with modern button conventions: `accessible-label` (consumer-facing), `static-color`, and `size` (`s|m|l|xl`). | ||
| - Variant aliases from 1st-gen (`variant="white|black"`) should be deprecated in favor of `static-color`. |
There was a problem hiding this comment.
Should deprecation information be in the API table and breaking changes section? ✨
Description
CONTRIBUTOR-DOCS:CONTRIBUTOR-DOCS/03_project-planning/03_components/close-button/migration-plan.mdCONTRIBUTOR-DOCS/03_project-planning/03_components/close-button/rendering-and-styling-migration-analysis.md2nd-gen/packages/swc/components/close-button/migration-guide.mdxCONTRIBUTOR-DOCS/03_project-planning/03_components/README.mdto index the new close-button plan + roadmap docs.spectrum-cssspectrum-twoclosebutton sourceMotivation and context
This work corrects scope and artifact type for the close-button epic.
The prior MDX was consumer migration documentation, but this stage requires internal migration planning docs (washing-machine Phase 1 style) before implementation.
This PR establishes the review surface for:
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Verify close-button migration planning docs were added and consumer guide was removed
2nd-gen/packages/swc/components/close-button/migration-guide.mdxis removedVerify phase-1 planning scope and design references
migration-plan.md, review TL;DR, Changes overview, Migration checklist, and Blockers and open questionsVerify contributor docs index was updated
Device review
Accessibility testing checklist
Keyboard (required — document steps below)
Screen reader (required — document steps below)