chore(accordion): accordion API & a11y (part 2)#6329
Draft
rise-erpelding wants to merge 25 commits into
Draft
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t one Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: f3767f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
34 tasks
Contributor
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Base automatically changed from
swc-1857-1858-1859
to
swc-1854/accordion-migration
May 21, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes the accordion migration by adding automated coverage and 1st-gen migration tooling. Depends on and targets #6300
In this PR (part 2 of 2):
accordion.test.ts): ARIA contract, toggle / cancel, exclusive open,allow-multiple, disabled item, hostdisabled, Space keyboard, heading level propagationaccordion.stories.ts: documents WAI-ARIA Accordion features and best practicessp-accordion-itemlabelattribute, per-itemlevelwhen it disagrees with parent,sp-accordion.focus(); withdeprecation.test.tscoveragedev-mode.test.tsupdated to allow deprecation-level warnings from default stories@adobe/spectrum-wcminor (2nd-gen accordion),@spectrum-web-components/accordionpatch (1st-gen deprecations)Motivation and context
Play tests verify the ARIA contract and interaction model from part 1 in a repeatable way. Deprecation warnings give 1st-gen consumers early notice of breaking API changes in Spectrum 2 before the tags are removed.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
2nd-gen play tests
OverviewTest,AriaContractTest,ToggleTest,ToggleEventTestpassDisabledItemTest,DisabledOpenItemTestpassHostDisabledTest,HostDisabledOpenItemTestpassSpaceKeyTestpassesExclusiveOpenTest,AllowMultipleTestpassHeadingLevelTestpasses1st-gen deprecation warnings
sp-accordion-item label="…"logs deprecation warninglevelthat disagrees with parent logs deprecationsp-accordion.focus()logs deprecation warningdev-mode.test.tspasses)yarn test:focus accordionin 1st-gen passesAccessibility story
a11yaddon reports no violations on the accessibility storyDevice review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
actionsslot behavior correct