Address lack of viewmedia and viewblock events on blog homepage and topic pages#37
Open
justinedelson wants to merge 2 commits intoadobecom:mainfrom
Open
Address lack of viewmedia and viewblock events on blog homepage and topic pages#37justinedelson wants to merge 2 commits intoadobecom:mainfrom
justinedelson wants to merge 2 commits intoadobecom:mainfrom
Conversation
|
Member
|
Very cool! I think @chrischrischris can take a look when he's back from PTO. @rgclayton may have some thoughts, too. |
justinedelson
force-pushed
the
rum-customization-bg-and-articles
branch
from
e717627 to
1339d03
Compare
justinedelson
force-pushed
the
rum-customization-bg-and-articles
branch
from
1339d03 to
cd0f225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While evaluating the RUM collected data for blog.adobe.com, I identified two semi-related issues:
cardblock is used),viewmediacheckpoints are not sent because the resulting DOM usesstyle="background-image..."rather than animgelement.article-feedblock is used),viewmediaandviewblockcheckpoints are not sent because the feed content is lazily loaded.Note - I have opted here to bundle both solutions into a single JS file. These could certainly be broken apart but it seemed useful to bundle them into a single file containing any future RUM enhancements. But obviously open to feedback if maintainers would prefer an alternate approach.
Test URLs