Skip to content

fixed-logo-placement#555

Open
ajey35 wants to merge 4 commits intoadoptium:mainfrom
ajey35:fix/logo-placement
Open

fixed-logo-placement#555
ajey35 wants to merge 4 commits intoadoptium:mainfrom
ajey35:fix/logo-placement

Conversation

@ajey35
Copy link
Copy Markdown
Contributor

@ajey35 ajey35 commented Nov 24, 2025

Description of Change

This PR fixes the issue #511 placement of the logo to ensure proper alignment and consistent appearance across the UI.

This is How It Looks Now!

image

Checklist

  1. npm test (Done)
  2. npm run build pass (Done)

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 24, 2025

Deploy Preview for adoptium-next ready!

Name Link
🔨 Latest commit 3328862
🔍 Latest deploy log https://app.netlify.com/projects/adoptium-next/deploys/6925b5562ca14d0008a50c9c
😎 Deploy Preview https://deploy-preview-555--adoptium-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.44%. Comparing base (42c7b30) to head (8be70c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   78.44%   78.44%           
=======================================
  Files         193      193           
  Lines        3693     3693           
  Branches     1094     1086    -8     
=======================================
  Hits         2897     2897           
  Misses        679      679           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xavierfacq
Copy link
Copy Markdown
Member

The problem is that the top of each icon is not aligned (same margin-top) inside the white block

image

Copy link
Copy Markdown
Member

@xavierfacq xavierfacq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment for the expected behavior

@ajey35
Copy link
Copy Markdown
Contributor Author

ajey35 commented Nov 25, 2025

Problem is not coming from any styling, all 4 logo's holds same styles . it is coming from image !
I think image of all these 4 logo's should be in same size and same format,,, 2 of them are same but other two got different,, I should format them to same size ?or is those logo images are available from ur side?

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 30, 2026

Deploy Preview for adoptium-next ready!

Name Link
🔨 Latest commit 8be70c7
🔍 Latest deploy log https://app.netlify.com/projects/adoptium-next/deploys/69ca213c5d56300008e3b0a9
😎 Deploy Preview https://deploy-preview-555--adoptium-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants