unixPB: adds roles xcode_offline and brew to Unix_Playbook#3417
unixPB: adds roles xcode_offline and brew to Unix_Playbook#3417mahdipub wants to merge 4 commits intoadoptium:masterfrom
Conversation
|
@mahdipub linter failures. |
Seems all resolved now. |
|
@mahdipub Ansible linter fixes needed by the looks. |
Lint removed. Could you please try again? |
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
5d627af to
d6921dd
Compare
The new Xcode_offline role will install xcode from an offline copy in /files dire. The brew role also will install brew on macos. Both rely on installing python on mac machine in advance.
d6921dd to
985251d
Compare
karianna
left a comment
There was a problem hiding this comment.
Pretty sure we already have scripts that install brew.
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/tasks/xcode_offline.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/brew/tasks/brew.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/brew/tasks/brew.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/brew/tasks/brew.yml
Outdated
Show resolved
Hide resolved
71d9c8d to
aee9b91
Compare
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/files/.place_holder
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/tasks/main.yml
Outdated
Show resolved
Hide resolved
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/brew/tasks/brew.yml
Outdated
Show resolved
Hide resolved
0b610c7 to
f6f2995
Compare
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Xcode_offline/tasks/main.yml
Outdated
Show resolved
Hide resolved
17fb05b to
7ea80ae
Compare
|
I might be missing something but the current roles already support this. checks for the |
This PR, meant to support wider range of xcode version and architecture. If we decided to merge this PR, it might be better to remove the one you mentioned. |
sxa
left a comment
There was a problem hiding this comment.
We have quite a few roles that are sourcing third party things from a directory called /Vendor_Files if it exists (A similar example being this for the XLC compiler on AIX) - would it be possible to do the same for this situation instead of requiring it to be a directory inside the checked out git tree?
This way of operations means we can support the /Vendor_Files directory being stored on the ansible tower/AWX server that is used to deploy to our machines.
ae50e6f to
691d005
Compare
691d005 to
2fe953a
Compare
@sxa that is done. |
|
/thaw |
Pull Request unblocked - code freeze is over.
The new Xcode_offline role will install xcode from an offline copy in /files dire. The brew role also will install brew on macos. Both rely on installing python on mac machine in advance.
Checklist