Skip to content

WinPB: Pin Cygwin Packages#4077

Merged
steelhead31 merged 1 commit intoadoptium:masterfrom
steelhead31:win_pin_cygwin
Oct 3, 2025
Merged

WinPB: Pin Cygwin Packages#4077
steelhead31 merged 1 commit intoadoptium:masterfrom
steelhead31:win_pin_cygwin

Conversation

@steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Sep 29, 2025

Fixes #4068

Due to issues with the most recent version of Cygwin, being unable to build JDK11, due to an upstream JDK bug, we need to temporarily pin the cygwin installation to install specific versions of packages.

This bug : https://bugs.openjdk.org/browse/JDK-8357657?focusedId=14792554&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel

Should be fixed in time for January 2026 release, once this bug is fixed and tested, we can revert this change, and test with the current package versions again.

Have built all JDK versions locally on vms using this version of cygwin...

Checklist

❌ JDK8 VPC : FAIL KNOWN ISSUE
✔️ : JDK11 VPC : https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Win2022,label=vagrant/2181/console
✔️ JDK17 VPC : https://ci.adoptium.net/job/VagrantPlaybookCheck/2187/
✔️ JDK21 VPC : https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Win2022,label=vagrant/2185/

@steelhead31 steelhead31 marked this pull request as ready for review September 29, 2025 08:07
@steelhead31 steelhead31 requested a review from sxa September 29, 2025 12:57
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did that URL come from? Using a non-official repository for this makes me somewhat nervous

@steelhead31
Copy link
Contributor Author

steelhead31 commented Sep 29, 2025

Where did that URL come from? Using a non-official repository for this makes me somewhat nervous

Its this.. http://www.crouchingtigerhiddenfruitbat.org/Cygwin/index.html , its pretty official and hosted on behalf of cygwin by one of its maintainers. Its known as the cygwin time machine... http://www.crouchingtigerhiddenfruitbat.org/Cygwin/timemachine.html and is pretty much a snapshot of the mirrors at various points in time.

Despite its rather interesting domain name :)

@sxa
Copy link
Member

sxa commented Sep 30, 2025

The http in there (as opposed to https) also makes me a little nervous. I'd suggest (ok I've already suggested it to you but I'm writing it down here!) that we consider looking at a cached bundle that we could store in somewhere like ci.adoptium.net/userContent (Or /Vendor_Files but since this is likely temporary that may not be necessary)

@steelhead31
Copy link
Contributor Author

Amending this to PR use a local cache of the required version of cygwin and its packages... returning to draft.

@steelhead31 steelhead31 marked this pull request as draft September 30, 2025 09:18
@steelhead31 steelhead31 marked this pull request as ready for review October 1, 2025 08:34
@steelhead31 steelhead31 requested a review from sxa October 1, 2025 10:13
@steelhead31
Copy link
Contributor Author

Tested locally and builds, 11,17 & 21 OK.. will run through VPC next.. JDK8 doesnt build due to issues with VS2022.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that
a) This is intended as a temporary measure until this is resolved upstream (Alternate option: We float a patch til then)
b) The JDK8 issue is unrelated to this PR and is a separate known issue

Thanks for tracking this down and resolving.

@karianna
Copy link
Contributor

karianna commented Oct 3, 2025

@steelhead31 you happy to merge now?

@steelhead31 steelhead31 force-pushed the win_pin_cygwin branch 2 times, most recently from be82113 to af4154e Compare October 3, 2025 11:54
@steelhead31 steelhead31 merged commit 9f3ecb8 into adoptium:master Oct 3, 2025
8 of 9 checks passed
@steelhead31 steelhead31 deleted the win_pin_cygwin branch October 3, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ansible: WinPB: Pin Version Of Cygwin & Components

3 participants