Remove Solaris From Vagrant Checker

[karianna]

We no longer build Solaris

[steelhead31]

Looks good.

[sxa]

I'm neutral on this - the code is still usable if someone outside adoptium wishes to use it, even if we won't actively maintain it. Noting that unless this is removed from the jenkins job too this will likely break our VPC job. Perhaps there should be a corresponding linked issue to cover all actions required here? ;-)

I'm not sure why the markdown has been shoehorned into this PR though - I feel that should be separate from the Solaris changes especially since they are not mentioned in the PR/commit title.

[karianna]

I'm neutral on this - the code is still usable if someone outside adoptium wishes to use it, even if we won't actively maintain it. Noting that unless this is removed from the jenkins job too this will likely break our VPC job. Perhaps there should be a corresponding linked issue to cover all actions required here? ;-)

I'm not sure why the markdown has been shoehorned into this PR though - I feel that should be separate from the Solaris changes especially since they are not mentioned in the PR/commit title.

I've only made the Vagrant Checker change as that was a GH Action triggered check on PR submissions (trying to keep that green). I agree there's a larger/further issue WRT to removing Solaris everywhere.

Have removed Markdown, will submit that separately.

[karianna]

#4259 Now has the bot

[sxa]

I've only made the Vagrant Checker change as that was a GH Action triggered check on PR submissions (trying to keep that green). I agree there's a larger/further issue WRT to removing Solaris everywhere.

vagrantPlayBookcheck.sh is not exclusive to GH actions. It was originally written (and is still run and is green) via https://ci.adoptium.net/job/VagrantPlaybookCheck/ - having said that I believe @steelhead31 was prevented from doing some updates on the host machine due to still supporting this particular VM :-)

[karianna]

@steelhead31 - Thoughts on this, do you prefer seeing the removal to unblock you or?

[steelhead31]

I'd be happy to have Solaris removed from the VPC, on my ever growing to do list, is a plan to update/migrate the Jenkins based VPC jobs, Im just waiting on the destiny of its current host. If we lose the host, then I'll likely rework some parts of this, and losing solaris even in the short term means I can look at bumping the pinned versions of Virtual Box, Vagrant, Python & Ansible, as they all had to be held back to support Solaris.

[sxa]

Based on Scott's comment and the intention to remove the ability to run it that will occur on the upgrade I'm ok with this.