unixPB: Ensure en_US.UTF-8 locale is generated on CentOS for build images

[sxa]

This is a potential fix for #3576 and resolves a difference between the x64 image and the aarch64 one. Note that with this change the configure error is suppressed whenLC_ALL=en_US.utf8 is in the environment (although a warning is generated when you set that variable):

bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf8): No such file or directory
bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf8): No such file or directory

Checklist

• commit message has one of the standard prefixes
• faq.md updated if appropriate
• other documentation is changed or added (if applicable)
• playbook changes run through VPC or QPC (if you have access): https://ci.adoptium.net/job/VagrantPlaybookCheck/2256/
• VPC/QPC not applicable for this PR
• for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

[andrew-m-leonard]

I note the OpenJDK make first checks for C.utf8 (ref: https://github.com/adoptium/jdk25u/blob/30a962c1ab3ef19159c3ea2179602289e7e6f3ac/make/autoconf/basic.m4#L139)
and then drops back to en_US.UTF-8

Should we alias to "C.utf8" ?

[sxa]

Should we alias to "C.utf8" ?

If that's possible then sure :-)

Also bear in mind that C.utf8 is not in the locales for the Linux/x64 image and we should probably strive for compatibility one way or another, and so we should be careful with testing if we're going to change such a default everywhere.

[andrew-m-leonard]

jdk-25+ will need C.UTF-8, so I think we need to discuss upgrading to Centos 8|9, at least for jdk-25+ ?
@steelhead31 fyi

[andrew-m-leonard]

Reproducibility across OS distributions maybe a consideration here? see #4284

[andrew-m-leonard]

From performing reproducible build tests this week, i've confirmed for jdk-23+ builds we need to be building using the OpenJDK recommended locale C.UTF-8. This is because it is "language neutral", which means it should then identically reproduce Japanese resource files and the like across OS distributions.

So I suggest we ensure the playbooks gen C.UTF-8 and en_US.UTF-8

I think ultimately this probably means we need to upgrade to Centos 8|9 ?

[sxa]

I think ultimately this probably means we need to upgrade to Centos 8|9 ?

As I've said elsewhere I'm generally in favour of this irrespective of this particular problem (the only negative having to have multiple build images), but I would be choosing at least 9 and preferably 10.

We could also consider using the later GCC and devkits with earlier Temurin releases in order to standardise on a newer base image (Proposed in adoptium/temurin-build#4209). As per some of the comments in there jdk8u puts up a little bit of a fight but we might still be able to make it work.

We could also use this as an opportunity to standardise on always pulling the Linux images from ghcr.io instead of dockerhub.