WIP [1]#MOD ical2json: add 1st version of param parsing#53
Open
sd-softdev wants to merge 1 commit intoadrianlee44:mainfrom
Open
WIP [1]#MOD ical2json: add 1st version of param parsing#53sd-softdev wants to merge 1 commit intoadrianlee44:mainfrom
sd-softdev wants to merge 1 commit intoadrianlee44:mainfrom
Conversation
sd-softdev
changed the title
Owner
|
Hi @sd-softdev, thanks for the PR. It looks like your IDE has replaced single quotes with double. This project is using prettier to format the code and default to single quotes. I see this PR is titled WIP. What's still missing in this PR from your perspective? Can you also provide test cases? |
Author
|
Hi @adrianlee44, yes, sorry, you're right. I will configure my IDE with the right prettier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.