[CLIENT-5057] Document which string operations create a new bin or no-op if a bin does not exist#1150
Draft
juliannguyen4 wants to merge 18 commits into
Draft
Conversation
…ditional / changes to tests. Also string ops tests should be refactored to make easier to change across the board.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## CLIENT-5057-refactor-string-ops-tests #1150 +/- ##
=========================================================================
+ Coverage 84.44% 85.38% +0.94%
=========================================================================
Files 99 101 +2
Lines 14062 14610 +548
=========================================================================
+ Hits 11874 12475 +601
+ Misses 2188 2135 -53 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…the same string bin. This reduces a good amount of tech debt.
… ops. TODO - Some of these are failing locally, so need to triage
…the same string bin. This reduces a good amount of tech debt.
juliannguyen4
changed the base branch from
dev
to
CLIENT-5057-refactor-string-ops-tests
…hange the pad string for pad_start and pad_end, but allow the target_length to be as big as NEEDLE
…non-existent bin name with value set to None instead of the bin name being absent in the bin dictionary. Add more e2e test cases that cover the rest of the string write operations that should be a no-op on a non-existent bin.
…document-string-ops-behavior-when-bin-is-missing
… in each operation's docstring instead of in the string write flags section. Also align with API docs standards by having string write ops' docstrings start with one sentence and have details in a following paragraph.
…ODO - to_string expression currently failing so need to debug it.
…g expression tests currently fail locally, so run in CI/CD
…failing-to-compile-with-Werror-flag
…ag' into CLIENT-5057-document-string-ops-behavior-when-bin-is-missing
…RING_TO_STRING like the to_string() operation helper.
…ions assumes that the bin contains a string. This usually would not be true for the ToString expression. This issue may also happen in other expressions like list, map etc.
juliannguyen4
changed the title
juliannguyen4
commented
Jul 15, 2026
| #: Default. Allow create or update. | ||
| DEFAULT = 0 | ||
| """ | ||
| Default. Create or replace. |
juliannguyen4
commented
Jul 15, 2026
| """ | ||
| Do not raise an error if a modify operation cannot be applied because | ||
| the target bin does not exist. The record is left unchanged. | ||
| Suppress an operation failure with the bin unchanged. |
Collaborator
Author
There was a problem hiding this comment.
awaiting more info on how to test this
…tring-ops-behavior-when-bin-is-missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs
https://aerospike-python-client--1150.org.readthedocs.build/en/1150/aerospike_helpers.html#aerospike_helpers.string_helpers.WriteFlags.DEFAULT
TODO