[CLIENT-5057] Fix string operations and expressions append and prepend not working#1155
Open
juliannguyen4 wants to merge 22 commits into
Open
[CLIENT-5057] Fix string operations and expressions append and prepend not working#1155juliannguyen4 wants to merge 22 commits into
append and prepend not working#1155juliannguyen4 wants to merge 22 commits into
Conversation
…ditional / changes to tests. Also string ops tests should be refactored to make easier to change across the board.
…the same string bin. This reduces a good amount of tech debt.
… ops. TODO - Some of these are failing locally, so need to triage
…the same string bin. This reduces a good amount of tech debt.
…hange the pad string for pad_start and pad_end, but allow the target_length to be as big as NEEDLE
…non-existent bin name with value set to None instead of the bin name being absent in the bin dictionary. Add more e2e test cases that cover the rest of the string write operations that should be a no-op on a non-existent bin.
…document-string-ops-behavior-when-bin-is-missing
… in each operation's docstring instead of in the string write flags section. Also align with API docs standards by having string write ops' docstrings start with one sentence and have details in a following paragraph.
…ODO - to_string expression currently failing so need to debug it.
…g expression tests currently fail locally, so run in CI/CD
…failing-to-compile-with-Werror-flag
…ag' into CLIENT-5057-document-string-ops-behavior-when-bin-is-missing
…RING_TO_STRING like the to_string() operation helper.
…ions assumes that the bin contains a string. This usually would not be true for the ToString expression. This issue may also happen in other expressions like list, map etc.
…tring-ops-behavior-when-bin-is-missing
…n to contain a string. This is because Aerospike expressions are strictly typed and we must pass in the bin value type
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1155 +/- ##
==========================================
+ Coverage 85.36% 85.38% +0.02%
==========================================
Files 101 101
Lines 14602 14609 +7
==========================================
+ Hits 12465 12474 +9
+ Misses 2137 2135 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Massif usage looks ok. |
atripathi-aerospike
approved these changes
Jul 16, 2026
|
nit: Could you please bit of Description in the PR will be great for quick understanding. Might be quick summary generated by the LLM works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.