Fix FieldInfo.equals() issue#234
Merged
Splatcrafter merged 1 commit intoaether-framework:developfrom Mar 26, 2026
Merged
Conversation
1) same Type.ref and Type.describe but different Type.codec -> objects not equal 2) same Type.codec but different Type.ref and Type.describe -> objects not equal
Member
|
I will look over it tomorrow morning. Thanks for your PR! |
Splatcrafter
added
bug
Splatcrafter
approved these changes
Mar 26, 2026
Splatcrafter
merged commit 70155fd
into
aether-framework:develop
10 of 11 checks passed
Member
|
Thank you for your contribution to this project! Your name will be recognized in the contributors list as part of the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed bug with equals method and added tests for same case
Type of Change
Related Issues
Closes issue
Changes
Verification
Checklist