Skip to content

434 make uap know about operations it should wait to finish #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BartolomeyKant merged 4 commits into from
Mar 4, 2026
Merged

434 make uap know about operations it should wait to finish #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8f4a8c
move index sequence to meta, make type list at and reverse by O(n) +
BartolomeyKant Mar 3, 2026
799e6fe
add logic for register actions in uap
BartolomeyKant Mar 3, 2026
8585123
move static assert into constructor to allow TAction forward declaration
BartolomeyKant Mar 3, 2026
752096f
make time sync use Uap
BartolomeyKant Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions aether/actions/action_ptr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,12 +106,13 @@ class OwnActionPtr : public ActionPtr<TAction> {
template <typename UAction>
friend class OwnActionPtr;

static_assert(ActionStoppable<TAction>::value, "TAction must be stoppable");
OwnActionPtr() = default;

template <typename... TArgs>
explicit OwnActionPtr(ActionContext action_context, TArgs&&... args)
: ActionPtr<TAction>{action_context, std::forward<TArgs>(args)...} {}
: ActionPtr<TAction>{action_context, std::forward<TArgs>(args)...} {
static_assert(ActionStoppable<TAction>::value, "TAction must be stoppable");
}

OwnActionPtr(OwnActionPtr<TAction>&& other) noexcept
: ActionPtr<TAction>{std::move(other)} {}
Expand Down Expand Up @@ -145,8 +146,8 @@ class OwnActionPtr : public ActionPtr<TAction> {

void reset() {
if (ActionPtr<TAction>::operator bool()) {
if (!ActionPtr<TAction>::operator->() -> IsFinished()) {
ActionPtr<TAction>::operator->() -> Stop();
if (!ActionPtr<TAction>::operator->()->IsFinished()) {
ActionPtr<TAction>::operator->()->Stop();
}
}
ActionPtr<TAction>::reset();
Expand Down
Loading