Skip to content

feat(judge): judge SEES screenshots for real visual review#275

Merged
jacsamell merged 1 commit into
mainfrom
feat/judge-sees-screenshots
Jun 3, 2026
Merged

feat(judge): judge SEES screenshots for real visual review#275
jacsamell merged 1 commit into
mainfrom
feat/judge-sees-screenshots

Conversation

@jacsamell
Copy link
Copy Markdown
Contributor

Problem

The browser pass captured screenshots and posted them to the PR, but the judge never saw the pixels. @playwright/mcp was omitting image responses (verified: zero image blocks reached the model), so browser_take_screenshot returned only a text file-link. The judge reviewed structure (accessibility snapshot) and computed styles, but was blind to the rendered visual — so it couldn't evaluate design.

Fix

  • _augment_playwright_args injects --image-responses allow → screenshots return inline → opus actually sees the rendered page.
  • Addendum instructs the judge to look at the returned image and judge the visual (layout, alignment, spacing, hierarchy, truncation/overflow, contrast, responsive breakage), holding the persona's "would a real user be worse off" bar (genuine visual defects, not style nits).

Stacks on #273 (storage_state, authed browsing) and #274 (screenshot relocation).

🤖 Generated with Claude Code

…esponses allow)

The browser pass captured screenshots but the judge never saw the pixels —
@playwright/mcp omitted image responses, so browser_take_screenshot returned
only a text file-link. The judge reviewed structure (accessibility snapshot)
but was blind to the rendered visual.

- _augment_playwright_args injects --image-responses allow so screenshots come
  back inline; opus actually sees layout/spacing/contrast/overflow.
- Addendum now tells the judge to LOOK at the returned image and judge the
  visual (alignment, hierarchy, truncation, contrast, responsive breakage),
  holding the persona's 'would a real user be worse off' bar — genuine visual
  defects, not style nits.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jacsamell jacsamell merged commit 3eb5b90 into main Jun 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@jacsamell, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 1 second. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 590528ad-0e38-4204-991a-155572d74bd5

📥 Commits

Reviewing files that changed from the base of the PR and between cf5a1f7 and 8e87462.

📒 Files selected for processing (2)
  • python/cube/automation/judge_panel.py
  • tests/automation/test_judge_panel_browser_gating.py

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant