Reflect weighted: Instead of killing photons, reduce their weight#100
Merged
Conversation
Member
Author
|
It would be nice to have a benchmark that checks reflectivity now, to see how this impacts performance as well. |
|
Bencher Report| Branch | 100/merge |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| build_objects | 📈 view plot 🚷 view threshold | 11.46 µs |
| build_tree | 📈 view plot 🚷 view threshold | 15.07 µs |
| diffusion_sim | 📈 view plot 🚷 view threshold | 1,402,700.00 µs |
| load_parameters | 📈 view plot 🚷 view threshold | 283.10 µs |
|
| Branch | 100/merge |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Mean Absolute Error | Measure (units) | Root Mean Squared Error | Measure (units) | Root Mean Squared Relative Error | Measure (units) | Total Variation L1 | Measure (units) |
|---|---|---|---|---|---|---|---|---|
| accuracy_diffusion | 📈 view plot 🚷 view threshold | 0.05 units | 📈 view plot 🚷 view threshold | 0.07 units | 📈 view plot 🚷 view threshold | 0.08 units | 📈 view plot 🚷 view threshold | 7.41 units |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the photons were killed based on the reflectance probability, which I think was a bug, because: