Conversation
hotfix missing aetherus_events
Fixup add missing mutex for ledger in multi-threaded sim
Resolve SrcId{Surf, Mat, MatSurf} for objects and light + UID support in output
Fixup diffusion configs for benches and &str representation for Error
There is some mess added by passing an extra argument to `fn surface(..., next_seq_id)`, because of a RAW hazard caused by PhotonCollector needing the updated Uid value early. TODO: Find a neat trick or Future like approach for storing the photon data
Adapt criterion benchmark for 0.4.x
…t to higher lvl structs
fixup engines and AttributeFuture implicit extend definition
Mark release 0.4.0
|
Bencher Report| Branch | 101/merge |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| build_objects | 📈 view plot 🚷 view threshold | 17.48 µs(-6.56%)Baseline: 18.71 µs | 92.09 µs (18.98%) |
| build_tree | 📈 view plot 🚷 view threshold | 15.16 µs(+1.70%)Baseline: 14.91 µs | 19.67 µs (77.06%) |
| diffusion_sim | 📈 view plot 🚷 view threshold | 2,987,700.00 µs(+42.05%)Baseline: 2,103,200.00 µs | 38,963,945.04 µs (7.67%) |
| load_parameters | 📈 view plot 🚷 view threshold | 228.59 µs(-10.54%)Baseline: 255.53 µs | 2,002.40 µs (11.42%) |
|
| Branch | 101/merge |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Mean Absolute Error | Benchmark Result Measure (units) (Result Δ%) | Upper Boundary Measure (units) (Limit %) | Root Mean Squared Error | Benchmark Result Measure (units) (Result Δ%) | Upper Boundary Measure (units) (Limit %) | Root Mean Squared Relative Error | Benchmark Result Measure (units) (Result Δ%) | Upper Boundary Measure (units) (Limit %) | Total Variation L1 | Benchmark Result Measure (units) (Result Δ%) | Upper Boundary Measure (units) (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| accuracy_diffusion | 📈 view plot 🚷 view threshold | 0.05 units | 0.10 units (52.25%) | 📈 view plot 🚷 view threshold | 0.07 units | 0.10 units (69.45%) | 📈 view plot 🚷 view threshold | 0.08 units | 0.10 units (80.11%) | 📈 view plot 🚷 view threshold | 7.41 units | 10.00 units (74.06%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges in the big bulk of development on the time-of-flight simulation with UID tagging using the aetherus-events Ledger.
.objWavefront fileWarning
This involves a breaking change in the configuration json5 file.
Check
benches/data/diffusion/scene/json5for changes