Require administrator permissions only when injecting.#17
Open
josago97 wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for your submission! There's a few things that come to mind when making these changes, in no specific order:
There should be some tests in the project already, perhaps it would be good to add a few that cover these cases so we can make sure nothing seriously breaks. |
Author
Also, we would need to change the way we access process modules because the Process class caches the collection the first time it's read, and if a new module is opened, it won't appear. It would be more convenient to call the native Windows API to access the updated list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Process.EnterDebugMode call requires administrator privileges. These are not needed for basic memory read/write operations, but are required for code injection. Therefore, we only call it when injection is needed, allowing regular memory access without prompting the user for elevated permissions.