fix: retire ZC1104, duplicate of ZC1188#1424
Merged
Merged
Conversation
ZC1104 and ZC1188 both fired on `export PATH=…` with the same advice, so every such line was reported twice. ZC1188 now owns that detection — its message adapts to a prepend or an append — so ZC1104 is stubbed to a no-op, following the retired-duplicate pattern already used for ZC1018 and ZC1019. Legacy `disabled_katas: [ZC1104]` lists keep parsing. ZC1103 (direct `PATH=$PATH:…` assignment, no `export`) is a distinct case and still fires. Removes 33 redundant findings from the violation baseline. KATAS.md regenerated; the ZC1104 test now asserts no finding.
redteamx
approved these changes
Jun 25, 2026
redteamx
left a comment
redteamx
left a comment
Collaborator
There was a problem hiding this comment.
Approved on review. ZC1104≡ZC1188 confirmed; retired-duplicate pattern (ZC1018/19); ZC1103 distinct; 33 redundant findings removed.
github-actions
Bot
added
docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ZC1104 and ZC1188 both fired on
export PATH=…with the same advice — every such line was double-reported. ZC1188 now owns that detection (its message adapts to a prepend or an append), so ZC1104 is stubbed to a no-op, following the retired-duplicate pattern already used for ZC1018/ZC1019. Legacydisabled_katas: [ZC1104]lists keep parsing.ZC1103 (direct
PATH=$PATH:…assignment, noexport) is a distinct case and still fires.Verification
go test ./...passes,golangci-lint0 issues, gocyclo clean, sweeps clean.