Skip to content

Various fixes to save-as dialog#17

Open
jnlon wants to merge 4 commits intoafonsotrepa:masterfrom
jnlon:save-as-fixes
Open

Various fixes to save-as dialog#17
jnlon wants to merge 4 commits intoafonsotrepa:masterfrom
jnlon:save-as-fixes

Conversation

@jnlon
Copy link

@jnlon jnlon commented Aug 31, 2019

This PR makes fixes various issues with the save-as dialog. The issues previously encountered with the dialog were:

  • Crashing in some circumstances due to string handling issues
  • It was not respecting the file name entered by the user in input box
  • It saved files in the home directory rather than the downloads directory

jnlon added 4 commits August 24, 2019 20:11
Fixes a crash when saving files without an extension
- Add missing "/" that prevented saving to downloads directory
- Replace duplicate calls to getExternalStoragePublicDirectory
- Fix typo in toast message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant