[pull] master from clockworklabs:master#553
Merged
Merged
Conversation
# Description of Changes
Sets the layout for DST tests and adds a basic test for
`spacetimedb-engine` via `engine` mod.
### Engine Test:
- Generates random schemas with tables, indexes, unique constraints,
primary keys, and sequence columns.
- Drives randomized interactions: begin mutable tx, insert, delete,
commit, and replay.
- Uses an in-memory commitlog/durability implementation so replay can
simulate shutdown/reopen without
disk.
- Define properties, check them while processing interactions.
### Upnext:
1. Fault-injection in commitlog.
2. Multi connection support (async api call-ing is not needed for
`engine` test as we expect caller/module to also be single-threaded).
3. Increase API coverage of engine, especially schema migrations.
4. Add more properties like check for sequences.
5. simulated Snapshots.
Further more integration tests like `standalone`, `replication` can be
added by implementing
[`traits.rs`](https://github.com/clockworklabs/SpacetimeDB/pull/5424/changes#diff-c9a6dc71550c7ccdd23b18de8ec8777aa6e2a34af2ddad0a5040537c8dffd1e6)
similar to `engine`.
looking to get general feedback on overall design for test effectiveness
and maintainability.
# API and ABI breaking changes
NA
# Expected complexity level and risk
It's a test addition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )