[pull] master from clockworklabs:master

crates/bindings-typescript/src/server/rng.ts

@@ -86,14 +86,13 @@ export function makeRandom(seed: Timestamp): Random {
   const random: Random = () => generateFloat64(rng);
 
   random.fill = array => {
-    const elem = array.at(0);
-    if (typeof elem === 'bigint') {
+    if (isBigIntArray(array)) {
       const upper = (1n << BigInt(array.BYTES_PER_ELEMENT * 8)) - 1n;
       for (let i = 0; i < array.length; i++) {
         array[i] = unsafeUniformBigIntDistribution(0n, upper, rng);
       }
-    } else if (typeof elem === 'number') {
-      const upper = (1 << (array.BYTES_PER_ELEMENT * 8)) - 1;
+    } else {
+      const upper = Math.pow(2, array.BYTES_PER_ELEMENT * 8) - 1;
       for (let i = 0; i < array.length; i++) {
         array[i] = unsafeUniformIntDistribution(0, upper, rng);
       }
@@ -111,3 +110,9 @@ export function makeRandom(seed: Timestamp): Random {
 
   return random;
 }
+
+function isBigIntArray(
+  array: IntArray
+): array is BigInt64Array | BigUint64Array {
+  return array instanceof BigInt64Array || array instanceof BigUint64Array;
+}

crates/bindings-typescript/tests/rng.test.ts

@@ -0,0 +1,46 @@
+import { describe, expect, test } from 'vitest';
+import { Timestamp } from '../src';
+import { makeRandom } from '../src/server/rng';
+
+describe('Random', () => {
+  test('fill is available and returns the same typed array', () => {
+    const random = makeRandom(new Timestamp(1n));
+    const bytes = new Uint8Array(16);
+
+    expect(random.fill).toBeTypeOf('function');
+    expect(random.fill(bytes)).toBe(bytes);
+    expect(bytes.some(byte => byte !== 0)).toBe(true);
+  });
+
+  test('fill supports all integer typed arrays', () => {
+    const random = makeRandom(new Timestamp(1n));
+    const arrays = [
+      new Int8Array(8),
+      new Uint8Array(8),
+      new Uint8ClampedArray(8),
+      new Int16Array(8),
+      new Uint16Array(8),
+      new Int32Array(8),
+      new Uint32Array(8),
+      new BigInt64Array(8),
+      new BigUint64Array(8),
+    ] as const;
+
+    for (const array of arrays) {
+      random.fill(array);
+      expect(Array.from(array).some(isNonZero)).toBe(true);
+    }
+  });
+
+  test('fill handles empty typed arrays', () => {
+    const random = makeRandom(new Timestamp(1n));
+    const bytes = new Uint8Array();
+
+    expect(random.fill(bytes)).toBe(bytes);
+    expect(bytes).toHaveLength(0);
+  });
+});
+
+function isNonZero(value: number | bigint): boolean {
+  return typeof value === 'bigint' ? value !== 0n : value !== 0;
+}

crates/codegen/src/csharp.rs

@@ -531,11 +531,7 @@ impl Lang for Csharp<'_> {
                 "public sealed class {csharp_table_class_name} : {base_class}<EventContext, {table_type}>"
             );
             indented_block(output, |output| {
-                writeln!(
-                    output,
-                    "protected override string RemoteTableName => \"{}\";",
-                    table.name
-                );
+                writeln!(output, "public override string RemoteTableName => \"{}\";", table.name);
                 writeln!(output);
 
                 // If this is a table, we want to generate event accessor and indexes

crates/codegen/tests/snapshots/codegen__codegen_csharp.snap

@@ -1718,7 +1718,7 @@ namespace SpacetimeDB
     {
         public sealed class LoggedOutPlayerHandle : RemoteTableHandle<EventContext, Player>
         {
-            protected override string RemoteTableName => "logged_out_player";
+            public override string RemoteTableName => "logged_out_player";
 
             public sealed class IdentityUniqueIndex : UniqueIndexBase<SpacetimeDB.Identity>
             {
@@ -1807,7 +1807,7 @@ namespace SpacetimeDB
     {
         public sealed class MyPlayerHandle : RemoteTableHandle<EventContext, Player>
         {
-            protected override string RemoteTableName => "my_player";
+            public override string RemoteTableName => "my_player";
 
             internal MyPlayerHandle(DbConnection conn) : base(conn)
             {
@@ -1858,7 +1858,7 @@ namespace SpacetimeDB
     {
         public sealed class PersonHandle : RemoteTableHandle<EventContext, Person>
         {
-            protected override string RemoteTableName => "person";
+            public override string RemoteTableName => "person";
 
             public sealed class AgeIndex : BTreeIndexBase<byte>
             {
@@ -1935,7 +1935,7 @@ namespace SpacetimeDB
     {
         public sealed class PlayerHandle : RemoteTableHandle<EventContext, Player>
         {
-            protected override string RemoteTableName => "player";
+            public override string RemoteTableName => "player";
 
             public sealed class IdentityUniqueIndex : UniqueIndexBase<SpacetimeDB.Identity>
             {
@@ -2024,7 +2024,7 @@ namespace SpacetimeDB
     {
         public sealed class TestDHandle : RemoteTableHandle<EventContext, TestD>
         {
-            protected override string RemoteTableName => "test_d";
+            public override string RemoteTableName => "test_d";
 
             internal TestDHandle(DbConnection conn) : base(conn)
             {
@@ -2073,7 +2073,7 @@ namespace SpacetimeDB
     {
         public sealed class TestFHandle : RemoteTableHandle<EventContext, TestFoobar>
         {
-            protected override string RemoteTableName => "test_f";
+            public override string RemoteTableName => "test_f";
 
             internal TestFHandle(DbConnection conn) : base(conn)
             {