fix: clarify mark-read target types#88
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mark-readtarget aliases, includingdm,direct-message, anddirect-conversationforconversation.Self-review fixes applied
Self-review prompt used: "Review the PR yourself, and take an outsider's view: Pretend you're a senior dev and you really don't like the way this PR is implemented; be brutally honest, and aim to make this PR much better with you feedback."
Finding: the initial CLI implementation normalized
mark-readtarget type inside the request payload, after resolving the agent id. That meant a pure local usage error could still require API/token setup before reporting the invalid target type.Recommended action/fix: normalize and validate the target type before
resolveAgentId(...)or any API request. Add a focused CLI test that runs with no API environment and expects the actionable invalid-target response.Applied:
mark-readnow computestargetTypebefore agent resolution, andtests/cli.test.tscovers the no-API-env invalid target path.Validation
npm test -- --run tests/api-auth.test.ts tests/cli.test.tsnpm testnpm run checkgit diff --checknpm run buildCloses #84