fix(knowledge): validate UUIDs in parse_causal_links (fixes #474)#478
Open
fix(knowledge): validate UUIDs in parse_causal_links (fixes #474)#478
Conversation
The LLM sometimes returns truncated UUIDs or git SHAs instead of valid fact UUIDs. These malformed IDs caused DuckDB ConversionException when cast to UUID in store_causal_links, silently dropping all causal links for the session. Add uuid.UUID() validation in parse_causal_links to filter out invalid IDs at the parser layer with a warning log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_valid_uuid()helper and UUID format validation inparse_causal_links()to filter out malformed IDs (truncated UUIDs, git SHAs, arbitrary strings) before they reach the DuckDB layerCloses #474
Changes
agent_fox/knowledge/extraction.py_is_valid_uuid()helper; added UUID validation with warning log inparse_causal_links()tests/unit/knowledge/test_extraction_causal.pyTestParseCausalLinksUUIDValidationclass with 6 testsTests
TestParseCausalLinksUUIDValidation: covers truncated UUIDs, git SHAs, valid UUIDs, mixed batches, plain strings, empty stringsVerification
Auto-generated by
af-fix.