feat(engine): deferred review injection — lazy promotion when slots idle (fixes #491)#495
Open
feat(engine): deferred review injection — lazy promotion when slots idle (fixes #491)#495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a
deferrednode status to eliminate the review flood at sync barriers. Review nodes whose coder dependencies are already completed are injected asdeferredinstead ofpending, and only promoted topendingwhen no coder candidates are available — ensuring implementation work is always prioritized over review work.Closes #491
Changes
agent_fox/graph/types.pyDEFERRED = "deferred"toNodeStatusenumagent_fox/engine/graph_sync.pypromote_deferred(limit)method; updatedis_stalled()to account for promotable deferred nodesagent_fox/engine/engine.py_defer_ready_reviews()helper called at init and hot-load; promotion logic in main dispatch loop and parallel refill pathtests/unit/engine/test_sync.pypromote_deferred()and deferred-aware stall detectiontests/unit/engine/test_deferred_reviews.py_defer_ready_reviews(), auto_pre exemption, full lifecycle integrationTests
test_sync.py: promote limit/skip/lifecycle, deferred stall detection (8 new tests)test_deferred_reviews.py: deferred injection for verifier/reviewer/audit-review, auto_pre exemption, coder exemption, promotion integration (7 new tests)Verification
Auto-generated by
af-fix.