fix(engine): skip redundant cleanup ingestion when barrier already ran (fixes #505)#509
Open
fix(engine): skip redundant cleanup ingestion when barrier already ran (fixes #505)#509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates double git ingestion at end-of-run by tracking whether a sync barrier already performed ingestion. The
_cleanup_infrastructurefunction now skipsrun_background_ingestionwhen the barrier flag is set, while still running it when no barrier fired (e.g., single-task plans orsync_interval=0).Closes #505
Changes
agent_fox/engine/run.py_barrier_ingestion_ranflag in_barrier_sync; guard cleanup ingestion behind flag checktests/unit/engine/test_double_ingestion.pyTests
test_cleanup_skips_ingestion_after_barrier— no double ingestiontest_cleanup_ingests_when_no_barrier_ran— cleanup still works when neededtest_barrier_failure_still_sets_flag— flag set even on ingestion failureVerification
Auto-generated by
af-fix.