feat(engine): restore eager pre-review with retry-predecessor (fixes #519)#530
Open
feat(engine): restore eager pre-review with retry-predecessor (fixes #519)#530
Conversation
…519) Add retry_predecessor=True to pre-review mode so critical findings convert to coder retries instead of permanent blocks. Lower the default pre_review_block_threshold from 3 to 1 and change the comparison from > to >= so a single confirmed critical triggers the feedback loop. Fix group-0 reviewer coder_node_id to correctly target group 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the v6-style tight quality feedback loop by adding
retry_predecessor=Trueto pre-review mode, lowering the blocking threshold from 3 to 1, and fixing the threshold comparison from>to>=. When pre-review finds critical issues, the coder gets a retry with findings injected as context instead of being permanently blocked.Closes #519
Changes
agent_fox/archetypes.pyretry_predecessor=Trueto pre-review ModeConfigagent_fox/core/config.pypre_review_block_thresholddefault from 3 to 1agent_fox/engine/blocking.py>to>=; fixed group-0 coder_node_id to target group 1agent_fox/engine/result_handler.py_retry_on_review_block()— converts blocks to retries via escalation ladderagent_fox/session/convergence.py>to>=with> 0guardtests/unit/engine/test_review_retry_predecessor.pyTests
test_review_retry_predecessor.py: threshold>=, group-0 fix, retry-on-block, archetype config, default thresholdtest_reviewer_consolidation.py,test_block_budget.py,test_convergence.pyVerification
Auto-generated by
af-fix.