feat(engine): add state transition validation to GraphSync (fixes #523)#531
Open
feat(engine): add state transition validation to GraphSync (fixes #523)#531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VALID_TRANSITIONStable and_transition()validation method toGraphSyncmark_*()methods now validate state transitions (warn on invalid, never crash)Closes #523
Changes
agent_fox/engine/graph_sync.pyVALID_TRANSITIONSclass constant,_transition()method with validation + structured logging,_transition_login-memory audit trail. Updatedmark_completed,mark_blocked,mark_in_progress,promote_deferredto route through_transition().tests/unit/engine/test_sync.pyTestTransitionValidation(8 tests) andTestTransitionLogging(3 tests)docs/memory.mdTests
TestTransitionValidation— valid transitions succeed, invalid transitions warn, terminal state enforced, unknown states don't crashTestTransitionLogging— audit trail recorded, cascade blocking logs all transitions, structured log messages emittedVerification