Skip to content

fix(ateom-microvm): guard subprocess exec against the child reaper#439

Open
Anish Ramasekar (aramase) wants to merge 1 commit into
agent-substrate:mainfrom
aramase:aramase/i/microvm_reap_guard
Open

fix(ateom-microvm): guard subprocess exec against the child reaper#439
Anish Ramasekar (aramase) wants to merge 1 commit into
agent-substrate:mainfrom
aramase:aramase/i/microvm_reap_guard

Conversation

@aramase

Copy link
Copy Markdown

Route synchronous mount/umount/cp through a shared reap-lock guard so the wait4(-1) reaper can't collect them first ("waitid: no child processes").

Fixes #418

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@HavenXia Haven Xia (HavenXia) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the package doc explains the reaper race well — could the per-symbol comments on reaper.go to be trimmed to one line each

Route synchronous mount/umount/cp through a shared reap-lock guard so the
wait4(-1) reaper can't collect them first ("waitid: no child processes").
@aramase

Copy link
Copy Markdown
Author

nit: the package doc explains the reaper race well — could the per-symbol comments on reaper.go to be trimmed to one line each

Haven Xia (@HavenXia) updated, PTAL!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ateom-microvm: "waitid: no child processes" flakes e2e restore

2 participants