Skip to content

Remove DebugClear method from ate-apiserver#446

Open
Troy Chiu (troychiu) wants to merge 2 commits into
agent-substrate:mainfrom
troychiu:remove-debug-clear
Open

Remove DebugClear method from ate-apiserver#446
Troy Chiu (troychiu) wants to merge 2 commits into
agent-substrate:mainfrom
troychiu:remove-debug-clear

Conversation

@troychiu

Copy link
Copy Markdown
Contributor

Fixes #443

  • Tests pass
  • Appropriate changes to documentation are included in the PR

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.actor_ref = ateapi_pb2.ActorRef(atespace=ATESPACE, name=self.actor_id)
still references the old ActorRef, could you replace all references to the old API in benchmarking/locust/ as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have discarded the changes to those files as they have been outdated. I believe it would be better to update them in a separate PR.

@juli4n

Copy link
Copy Markdown
Collaborator

Note that we are still making breaking changes to the API, so we need some way to delete all data. The spirit of #443 was to remove the endpoint from the Control service, but might need the ability to wipe out everything for a bit longer. Maybe we can separate the method to a separate Debug gRPC service?

@troychiu

Copy link
Copy Markdown
Contributor Author

Note that we are still making breaking changes to the API, so we need some way to delete all data. The spirit of #443 was to remove the endpoint from the Control service, but might need the ability to wipe out everything for a bit longer. Maybe we can separate the method to a separate Debug gRPC service?

That makes sense. Let me update the PR accordingly. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DebugClear method from ate-apiserver

3 participants