Allow spawning codex by passing cli subcommand#127
Merged
Conversation
AlexandrSuhinin
approved these changes
May 5, 2026
Resolve conflict in src/index.ts caused by agentclientprotocol#135 (codex app-server is now started via node when using the bundled codex.js). Drop the local getCodexPath() helper and pass process.env["CODEX_PATH"] (possibly undefined) to both startCodexConnection and runCodexCli, mirroring the same bundled-path + node-spawn fallback inside runCodexCli.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows clients to implement interactive terminal authentication, similar to
--cliinclaude-agent-acp:https://github.com/agentclientprotocol/claude-agent-acp/blob/5b9311938d97f47400debd66f2b4792e50639c6b/src/index.ts#L7-L36
I did not change the reported auth methods in this PR.