fix(mcp): add minItems/maxItems to ctx_get ids schema#35
Open
koteshyelamati wants to merge 1 commit into
Open
Conversation
The ctx_get handler enforces that ids must have 1-GET_IDS_MAX elements, but the inputSchema declared neither minItems nor maxItems. MCP clients had no way to know the array bounds up front. Adds minItems: 1 and maxItems: GET_IDS_MAX to the ids schema and updates the description to mention the lower bound. Runtime checks in ctxGet remain as the authoritative guard. Closes agentctxhq#34
Contributor
|
@koteshyelamati thanks for the contribution The pr is missing the test assertion in test/mcp/tools.test.ts that the issue explicitly requires |
Author
|
Thanks @Deepam02 — you're right. I'll add the test assertion in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ctx_get handler enforces that ids must have 1-GET_IDS_MAX elements, but the inputSchema declared neither minItems nor maxItems. MCP clients had no way to know the array bounds up front.
Adds minItems: 1 and maxItems: GET_IDS_MAX to the ids schema and updates the description to mention the lower bound. Runtime checks in ctxGet remain as the authoritative guard.
Closes #34
Summary
Related Issues
Type of Change
How Has This Been Tested?
Checklist