Skip to content

fix: include only reinforced preferences in digest #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kingrubic wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: include only reinforced preferences in digest #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/agentctx/src/consolidate/digest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export function buildDigestSections(
const prefs = currentRecords(
db,
GLOBAL_PROJECT_ID,
"type = 'preference' AND confidence != 'inferred'",
"type = 'preference' AND confidence = 'reinforced'",
"score DESC, recorded_at DESC",
);
if (prefs.length > 0) {
Expand Down
9 changes: 9 additions & 0 deletions packages/agentctx/test/consolidate/run.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,14 @@ describe("agentctx consolidate", () => {
body: "not yet reinforced",
confidence: "inferred",
});
seed({
projectId: GLOBAL_PROJECT_ID,
scope: "global",
type: "preference",
title: "Explicit but not reinforced preference",
body: "explicit only",
confidence: "explicit",
});

expect(await runConsolidate(t.env)).toBe(0);

Expand All @@ -144,6 +152,7 @@ describe("agentctx consolidate", () => {
expect(digest?.sections.handover).toContain("extraction pipeline");
expect(digest?.sections.globalPreferences).toContain("Prefers arrow functions");
expect(digest?.sections.globalPreferences).not.toContain("Unproven");
expect(digest?.sections.globalPreferences).not.toContain("Explicit but not reinforced");
expect(digest?.sections.mcpHint).toContain("ctx_search");

const total = Object.values(digest?.sections ?? {}).reduce(
Expand Down
Loading