refactor: share describeError helper across CLI, hooks, extract, and MCP#94
Open
barry166 wants to merge 1 commit into
Open
refactor: share describeError helper across CLI, hooks, extract, and MCP#94barry166 wants to merge 1 commit into
barry166 wants to merge 1 commit into
Conversation
Issue agentctxhq#89 called out repeated unknown-error stringification helpers across hooks, extraction, MCP, and CLI surfaces. This change adds one shared helper, switches the duplicated and inlined call sites to it, and adds a small regression test for Error and non-Error throwables.\n\nConstraint: Keep behavior unchanged while removing the duplicated helper logic\nRejected: Leave remaining inline sites untouched | would keep the same single-purpose duplication inside the issue scope\nConfidence: high\nScope-risk: narrow\nReversibility: clean\nDirective: Reuse describeError for future unknown-error reporting instead of adding local ternaries\nTested: npm test --workspace @agentctxhq/agentctx; npm run typecheck --workspace @agentctxhq/agentctx; npm run build --workspace @agentctxhq/agentctx; npm run lint\nNot-tested: End-to-end npm package install on a fresh machine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
describeError(error)helper for unknown-error stringificationErrorand non-ErrorthrowablesRelated Issues
Closes #89
Type of Change
How Has This Been Tested?
npm test --workspace @agentctxhq/agentctxnpm run typecheck --workspace @agentctxhq/agentctxnpm run build --workspace @agentctxhq/agentctxnpm run lintDisclosure
Checklist