-
Notifications
You must be signed in to change notification settings - Fork 0
feat: learn subject-plugin contract implementation + French story ladder (learn uplift) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8178bc3
content(stories): add beginner (A1/A2) graded-reader stories
OriNachum ccc6ec7
content(stories): add intermediate (B1) graded-reader stories
OriNachum e4c2a41
content(stories): add advanced (B2/C1) stories + pipeline docs
OriNachum 619412d
merge t7a: French graded-reader story ladder (11 stories, A1-C1)
OriNachum 258ca14
feat: implement the learn subject-plugin contract (reference tutor)
OriNachum ee51ab9
merge t4: learn subject-plugin contract implementation (8 tutor verbs…
OriNachum df3de29
chore: bump to 0.5.0 for the learn-uplift PR
OriNachum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| { | ||
| "schema_version": "1.0", | ||
| "kind": "story", | ||
| "id": "dev-cafe", | ||
| "subject": "french", | ||
| "title": "Un cafe, s'il vous plait", | ||
| "level": "beginner", | ||
| "level_detail": "A1", | ||
| "language": "fr", | ||
| "summary": "Paul orders a coffee and a croissant, then pays at a small cafe.", | ||
| "body": "Paul entre dans un petit cafe. Il regarde le menu.\n\n« Bonjour ! Je voudrais un cafe et un croissant, s'il vous plait. »\n\nLe serveur sourit. « Tres bien. Ca fait trois euros cinquante. »\n\nPaul paie et s'assoit pres de la fenetre. Le cafe est chaud et le croissant est delicieux.", | ||
| "glossary": [ | ||
| { | ||
| "term": "je voudrais", | ||
| "definition": "I would like", | ||
| "note": "The polite way to order; softer than « je veux »." | ||
| }, | ||
| { | ||
| "term": "ca fait trois euros cinquante", | ||
| "definition": "that comes to three euros fifty" | ||
| }, | ||
| { | ||
| "term": "pres de la fenetre", | ||
| "definition": "near the window" | ||
| } | ||
| ], | ||
| "exercises": [ | ||
| { | ||
| "id": "dev-cafe-q1", | ||
| "type": "multiple_choice", | ||
| "item_id": "fr.food.commander", | ||
| "prompt": "Qu'est-ce que Paul commande ?", | ||
| "choices": [ | ||
| "Un cafe et un croissant", | ||
| "Un the et une tarte", | ||
| "Un jus et un pain" | ||
| ], | ||
| "answer": "Un cafe et un croissant" | ||
| }, | ||
| { | ||
| "id": "dev-cafe-q2", | ||
| "type": "multiple_choice", | ||
| "item_id": "fr.numbers.prix", | ||
| "prompt": "Combien Paul paie-t-il ?", | ||
| "choices": [ | ||
| "Deux euros", | ||
| "Trois euros cinquante", | ||
| "Dix euros" | ||
| ], | ||
| "answer": "Trois euros cinquante" | ||
| }, | ||
| { | ||
| "id": "dev-cafe-q3", | ||
| "type": "cloze", | ||
| "item_id": "fr.food.commander", | ||
| "prompt": "« Je ___ un cafe, s'il vous plait. »", | ||
| "answer": "voudrais" | ||
| } | ||
| ], | ||
| "audio": null, | ||
| "source": { | ||
| "generator": "hand-authored", | ||
| "reviewed_by": "french-cli t4", | ||
| "generated_at": "2026-07-11" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| { | ||
| "schema_version": "1.0", | ||
| "kind": "story", | ||
| "id": "dev-directions", | ||
| "subject": "french", | ||
| "title": "Ou est la gare ?", | ||
| "level": "intermediate", | ||
| "level_detail": "A2", | ||
| "language": "fr", | ||
| "summary": "Lost in town, Hugo asks a passer-by for the way to the station.", | ||
| "body": "Hugo est perdu. Il cherche la gare.\n\nIl arrete une dame dans la rue. « Pardon, madame. Ou est la gare, s'il vous plait ? »\n\n« C'est facile », repond la dame. « Continuez tout droit, puis tournez a gauche au coin. La gare est a cinq minutes a pied. »\n\n« Merci beaucoup ! » dit Hugo. Il tourne a gauche et trouve la gare tout de suite.", | ||
| "glossary": [ | ||
| { | ||
| "term": "je cherche", | ||
| "definition": "I am looking for", | ||
| "note": "From « chercher »; « je cherche la gare »." | ||
| }, | ||
| { | ||
| "term": "tout droit", | ||
| "definition": "straight ahead" | ||
| }, | ||
| { | ||
| "term": "tournez a gauche", | ||
| "definition": "turn left", | ||
| "note": "« a droite » is to the right." | ||
| }, | ||
| { | ||
| "term": "a cinq minutes a pied", | ||
| "definition": "five minutes away on foot" | ||
| } | ||
| ], | ||
| "exercises": [ | ||
| { | ||
| "id": "dev-directions-q1", | ||
| "type": "multiple_choice", | ||
| "item_id": "fr.ville.directions", | ||
| "prompt": "Qu'est-ce que Hugo cherche ?", | ||
| "choices": [ | ||
| "La gare", | ||
| "Le marche", | ||
| "Le cafe" | ||
| ], | ||
| "answer": "La gare" | ||
| }, | ||
| { | ||
| "id": "dev-directions-q2", | ||
| "type": "cloze", | ||
| "item_id": "fr.ville.directions", | ||
| "prompt": "Continuez tout droit, puis tournez a ___ au coin.", | ||
| "answer": "gauche" | ||
| }, | ||
| { | ||
| "id": "dev-directions-q3", | ||
| "type": "short_answer", | ||
| "item_id": "fr.ville.directions", | ||
| "prompt": "La gare est a combien de minutes a pied ?", | ||
| "rubric": "Passes with « cinq minutes » (or « 5 minutes »); anything else is fail." | ||
| } | ||
| ], | ||
| "audio": null, | ||
| "source": { | ||
| "generator": "hand-authored", | ||
| "reviewed_by": "french-cli t4", | ||
| "generated_at": "2026-07-11" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| { | ||
| "schema_version": "1.0", | ||
| "kind": "story", | ||
| "id": "dev-marche", | ||
| "subject": "french", | ||
| "title": "Au marche du samedi", | ||
| "level": "beginner", | ||
| "level_detail": "A1", | ||
| "language": "fr", | ||
| "summary": "Claire buys apples, bread, and cheese at the Saturday market.", | ||
| "body": "Le samedi matin, Claire va au marche.\n\nElle achete un kilo de pommes rouges. « Bonjour, madame ! Un kilo de pommes, s'il vous plait. » Le vendeur dit : « Voila, ca fait deux euros. »\n\nEnsuite, Claire achete une baguette et un fromage de chevre. Elle aime beaucoup le fromage.\n\nA midi, elle rentre a la maison et prepare un dejeuner simple : du pain, du fromage et une pomme.", | ||
| "glossary": [ | ||
| { | ||
| "term": "le marche", | ||
| "definition": "the market", | ||
| "note": "« un marche en plein air » is an open-air market." | ||
| }, | ||
| { | ||
| "term": "un kilo de pommes", | ||
| "definition": "a kilo of apples", | ||
| "note": "Quantities take « de »: un kilo de, une tranche de." | ||
| }, | ||
| { | ||
| "term": "le fromage de chevre", | ||
| "definition": "goat cheese" | ||
| }, | ||
| { | ||
| "term": "elle rentre a la maison", | ||
| "definition": "she goes back home" | ||
| } | ||
| ], | ||
| "exercises": [ | ||
| { | ||
| "id": "dev-marche-q1", | ||
| "type": "multiple_choice", | ||
| "item_id": "fr.food.marche", | ||
| "prompt": "Quand est-ce que Claire va au marche ?", | ||
| "choices": [ | ||
| "Le samedi matin", | ||
| "Le dimanche soir", | ||
| "Le lundi a midi" | ||
| ], | ||
| "answer": "Le samedi matin" | ||
| }, | ||
| { | ||
| "id": "dev-marche-q2", | ||
| "type": "multiple_choice", | ||
| "item_id": "fr.numbers.prix", | ||
| "prompt": "Combien coutent les pommes ?", | ||
| "choices": [ | ||
| "Deux euros", | ||
| "Quatre euros", | ||
| "Dix euros" | ||
| ], | ||
| "answer": "Deux euros" | ||
| }, | ||
| { | ||
| "id": "dev-marche-q3", | ||
| "type": "cloze", | ||
| "item_id": "fr.food.marche", | ||
| "prompt": "Claire achete une baguette et un ___ de chevre.", | ||
| "answer": "fromage" | ||
| }, | ||
| { | ||
| "id": "dev-marche-q4", | ||
| "type": "short_answer", | ||
| "item_id": "fr.food.marche", | ||
| "prompt": "Qu'est-ce que Claire mange a midi ?", | ||
| "rubric": "Any answer naming bread, cheese, and/or an apple (du pain, du fromage, une pomme) passes; one item is partial." | ||
| } | ||
| ], | ||
| "audio": null, | ||
| "source": { | ||
| "generator": "hand-authored", | ||
| "reviewed_by": "french-cli t4", | ||
| "generated_at": "2026-07-11" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| { | ||
| "schema_version": "1.0", | ||
| "kind": "story", | ||
| "id": "fr-a1-la-rentree", | ||
| "subject": "french", | ||
| "title": "La rentrée de Nina", | ||
| "level": "beginner", | ||
| "level_detail": "A1", | ||
| "language": "fr", | ||
| "summary": "It is Nina's first day back at school, and she is a little nervous about her new teacher.", | ||
| "body": "Aujourd'hui, c'est la rentrée. Nina a huit ans et elle est un peu nerveuse.\n\nLe matin, elle se réveille tôt. Elle prend son petit-déjeuner : du pain, du beurre et un chocolat chaud. Sa mère prépare son cartable avec des cahiers, des crayons et une nouvelle trousse bleue.\n\n« Tu es prête, Nina ? » demande sa mère. « Oui, mais j'ai un peu peur, » répond Nina. « Il y a une nouvelle maîtresse cette année. »\n\nÀ l'école, Nina retrouve ses amis dans la cour. Ils sont contents de se revoir après les vacances d'été. La maîtresse s'appelle Madame Dubois. Elle sourit et dit : « Bonjour, les enfants ! Bienvenue dans la classe de CE2. »\n\nPendant la journée, les élèves apprennent leurs nouveaux noms, rangent leurs affaires et écoutent une histoire. À midi, Nina mange à la cantine avec sa meilleure amie, Léa.\n\nLe soir, Nina raconte sa journée à ses parents. « La maîtresse est très gentille, » dit-elle. « Et j'ai une nouvelle amie dans ma classe ! »", | ||
| "glossary": [ | ||
| { | ||
| "term": "la rentrée", | ||
| "definition": "back-to-school (day), the start of the school year" | ||
| }, | ||
| { | ||
| "term": "le cartable", | ||
| "definition": "the school bag" | ||
| }, | ||
| { | ||
| "term": "la trousse", | ||
| "definition": "the pencil case" | ||
| }, | ||
| { | ||
| "term": "la maîtresse", | ||
| "definition": "the (female) teacher", | ||
| "note": "Used for a primary-school teacher; le maître for a man." | ||
| }, | ||
| { | ||
| "term": "la cour", | ||
| "definition": "the schoolyard" | ||
| }, | ||
| { | ||
| "term": "la cantine", | ||
| "definition": "the school canteen" | ||
| }, | ||
| { | ||
| "term": "avoir peur", | ||
| "definition": "to be scared/afraid" | ||
| } | ||
| ], | ||
| "exercises": [ | ||
| { | ||
| "id": "fr-a1-la-rentree-q1", | ||
| "type": "multiple_choice", | ||
| "item_id": "fr.story.fr-a1-la-rentree.1", | ||
| "prompt": "Quel âge a Nina ?", | ||
| "choices": ["Six ans", "Huit ans", "Dix ans"], | ||
| "answer": "Huit ans" | ||
| }, | ||
| { | ||
| "id": "fr-a1-la-rentree-q2", | ||
| "type": "multiple_choice", | ||
| "item_id": "fr.story.fr-a1-la-rentree.2", | ||
| "prompt": "Comment s'appelle la maîtresse de Nina ?", | ||
| "choices": ["Madame Dubois", "Madame Martin", "Madame Petit"], | ||
| "answer": "Madame Dubois" | ||
| }, | ||
| { | ||
| "id": "fr-a1-la-rentree-q3", | ||
| "type": "true_false", | ||
| "item_id": "fr.story.fr-a1-la-rentree.3", | ||
| "prompt": "Nina n'a pas d'amis à l'école.", | ||
| "answer": "false" | ||
| }, | ||
| { | ||
| "id": "fr-a1-la-rentree-q4", | ||
| "type": "open", | ||
| "item_id": "fr.story.fr-a1-la-rentree.4", | ||
| "prompt": "Pourquoi Nina a-t-elle un peu peur le matin de la rentrée ?", | ||
| "rubric": "Passes if the answer mentions the new teacher or general first-day nerves; partial if it just says 'she is scared' with no reason." | ||
| } | ||
| ], | ||
| "audio": null, | ||
| "source": { | ||
| "generator": "hand-authored", | ||
| "reviewed_by": "learn-cli t7a", | ||
| "generated_at": "2026-07-11" | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Changelog entries lack rationale
📘 Rule violation⚙ MaintainabilityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools