fix(smoke): skip data/raw in secret scan#4
Merged
Conversation
Raw evidence under data/raw/ contains API responses and third-party payloads that are not repo-authored secrets. Skipping them prevents false-positive secret alerts from ingestion artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The smoke test's secret scanner walks every file in the repo. Once a user starts running ingestion, fills with GitHub API responses, JSON payloads, and third-party content. These trigger false-positive secret alerts (e.g. GitHub event IDs that look like AWS keys, Nostr pubkeys that match secret patterns).
Fix
Skip in the secret scan loop, mirroring the pattern already used for the directory.
Impact
Already verified in AOS repo
This fix has been running in the AOS mini-agi repo (commit 7813e03) without issues.