fix(workflows): skip maintainer gate for maintainer-authored PRs#10
Merged
Conversation
author_association only reports MEMBER for public org membership; with private membership a maintainer's own PR could never clear the gate (authors cannot approve their own PRs). Skip when the PR author is in MAINTAINERS. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gate's job-level
ifskips on author_association MEMBER/OWNER, but GitHub only reports MEMBER when the author's org membership is public, so a maintainer with private membership gets CONTRIBUTOR and the gate demands an approval the author cannot give (authors cannot approve their own PRs). This keeps the base-branch check in the job-levelif, moves the association skip in-script, and adds an explicit skip when the PR author is in MAINTAINERS; confirmed live on cmcp#291, where the gate failed while all tests passed.Note: this PR is itself gate-blocked by the bug it fixes. Approve and re-run the gate, or admin-merge.
Generated with Claude Code