fix(workflows): re-evaluate maintainer gate on reviews, require head-SHA approval#159
Merged
Merged
Conversation
…SHA approval Ports agentrust-io/.github#8. Refs agentrust-io/.github#9. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the maintainer-gate fix from agentrust-io/.github#8 into this repo's copy of
require-maintainer-approval.yml. Refs agentrust-io/.github#9.This repo's copy had diverged completely from the canonical gate: it triggered only on
pull_request_review: [submitted], inspected just the triggering review's author against a team-membership lookup that fell back to an empty list (warn-only, never blocking), and never ran on PR open/synchronize, so no gate status was ever set on new PRs. None of the components the fix patches existed in this variant, so the file is replaced with the canonical fixed version from .github#8:pull_request_target(opened/synchronize/reopened) pluspull_request_review: [submitted, dismissed]triggers, with the base-branch check at the job-levelif.commit_idequal to the PR head SHA fetched at evaluation time.listReviewsviagithub.paginate.This also replaces the unpinned
actions/github-script@v9with the canonical SHA pin.Validated with
yaml.safe_load.Note: This PR is itself blocked by the broken gate it fixes. Approve then re-run the gate workflow manually, or admin-merge.
Generated with Claude Code